fixed windows build workflow

ozguronsoy · Dec 11, 2024 · 03bb0c7 · 03bb0c7
1 parent 2c7df98
commit 03bb0c7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/.github/workflows/build_linux.yml b/.github/workflows/build_linux.yml
@@ -14,7 +14,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  build_gcc:
+  gcc:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -45,7 +45,7 @@ jobs:
         working-directory: ${{github.workspace}}
         run: ./hephaudio_test
 
-  build_clang:
+  clang:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml
@@ -14,7 +14,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  build_msvc:
+  msvc:
     runs-on: windows-latest
 
     steps:
@@ -27,6 +27,9 @@ jobs:
           -DCMAKE_C_COMPILER=cl
           -DCMAKE_CXX_COMPILER=cl
           -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+          -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=${{github.workspace}}
+          -DCMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG=${{github.workspace}}
+          -DCMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE=${{github.workspace}}
           -DENABLE_TESTS=On
           -DCMAKE_CXX_FLAGS='-w'
           .

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.25)
+cmake_minimum_required(VERSION 3.28)
 
 set(HEPHAUDIO_VERSION_MAJOR 3)
 set(HEPHAUDIO_VERSION_MINOR 1)
@@ -366,9 +366,4 @@ if (ENABLE_TESTS)
         gtest_main
     )
 
-    install(
-        TARGETS ${HEPHAUDIO_TEST} 
-        DESTINATION ${HEPHAUDIO_BUILD_DIR}
-    )
-
 endif ()
diff --git a/README.md b/README.md
@@ -31,7 +31,7 @@ HephAudio is a cross-platform audio library that provides:<br>
 
 ### Install Dependencies
 
-- Install [CMake](https://cmake.org/download/) 3.25.0 or higher.<br>
+- Install [CMake](https://cmake.org/download/) 3.28.0 or higher.<br>
 - Install ALSA development library for **Linux**.<br>
 - build FFmpeg and libmysofa for **macOS** and **iOS**.<br>
 
@@ -50,7 +50,7 @@ HephAudio is a cross-platform audio library that provides:<br>
 
 An example cmake file:
 ```
-cmake_minimum_required(VERSION 3.25)
+cmake_minimum_required(VERSION 3.28)
 
 # your project name
 project("my_application")
@@ -135,7 +135,7 @@ endif()
 An example cmake file:
 
 ```
-cmake_minimum_required(VERSION 3.25)
+cmake_minimum_required(VERSION 3.28)
 
 # your project name
 project("my_application")