Replace usage of sscanf with strtol to remove cppcheck inline suppres…

…sion
owasp-modsecurity · Oct 21, 2024 · 4e68edf · 4e68edf
1 parent cdaf32f
commit 4e68edf
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/rules_set_properties.cc b/src/rules_set_properties.cc
@@ -33,10 +33,8 @@ void ConfigUnicodeMap::loadConfig(std::string f, double configCodePage,
     const char *p = NULL;
     char *savedptr = NULL;
     const char *ucode = NULL;
-    int code = 0;
     int found = 0;
     int length = 0;
-    int Map = 0;
     int processing = 0;
 
     driver->m_unicodeMapTable.m_set = true;
@@ -102,10 +100,10 @@ void ConfigUnicodeMap::loadConfig(std::string f, double configCodePage,
 
             if (mapping != NULL) {
                 ucode = strtok_r(mapping, ":", &hmap);
-                sscanf(ucode, "%x", &code); // cppcheck-suppress invalidScanfArgType_int
-                sscanf(hmap, "%x", &Map);   // cppcheck-suppress invalidScanfArgType_int
+                int code = strtol(ucode, nullptr, 16);
+                int map = strtol(hmap, nullptr, 16);
                 if (code >= 0 && code <= 65535)    {
-                    driver->m_unicodeMapTable.m_unicodeMapTable->change(code, Map);
+                    driver->m_unicodeMapTable.m_unicodeMapTable->change(code, map);
                 }
 
                 free(mapping);