Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce the import weight of internal/primordials #16209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

reduce the import weight of internal/primordials #16209

wants to merge 2 commits into from
+193 −315

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 7, 2025 •
edited
Loading

this will allow SafeArrayIterator, SafeStringIterator, SafeMap, SafeSet to be used easily without incurring the cost of preloading all curried intrinsics

@robobun
Copy link

robobun commented Jan 7, 2025 •
edited
Loading

Updated 1:08 AM PT - Jan 7th, 2025

❌ @nektro, your commit ec0987e has 1 failures in #9079:

🧪   try this PR locally:

bunx bun-pr 16209

@nektro nektro marked this pull request as ready for review January 7, 2025 11:10
@nektro nektro requested a review from cirospaciari January 7, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirospaciari cirospaciari Awaiting requested review from cirospaciari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nektro @robobun