fix(bundler) Typescript paths with packages external fix #16163
+49
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperclover
approved these changes
Jan 6, 2025
src/resolver/resolver.zig
Outdated
| return MatchResult{ .path_pair = .{ | ||
| .primary = _result.path_pair.primary, | ||
| .secondary = auto_main_result.path_pair.primary, | ||
| }, .diff_case = _result.diff_case, .dirname_fd = _result.dirname_fd, .package_json = package_json, .file_fd = auto_main_result.file_fd, .is_node_module = is_node_module_folder }; |
There was a problem hiding this comment.
this should have a trailing comma to tell the formatter to use multiple lines
zpix1
force-pushed
the
zpix1/#14721-typescript-paths-with-packages-external-fix
branch
from
63ed161 to
33184af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch fixes issue #14721, where packages=external option of bundler incorrectly excluded packages which were imported with mapped path (using tsconfig path aliases).
How did you verify your code works?
I wrote automated tests
bun-debug test test-file-name.test)