Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6565 Move admin user search to Elasticsearch, add past emails and username search #4801

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

AO3-6565 Move admin user search to Elasticsearch, add past emails and username search #4801

wants to merge 23 commits into from

Conversation

weeklies
Copy link
Contributor

@weeklies weeklies commented Apr 28, 2024 •
edited
Loading

Issue

https://otwarchive.atlassian.net/browse/AO3-6565

Purpose

Move admin user search to Elasticsearch, add past emails and username search

Testing Instructions

Test admin user search in a variety of ways, including past emails and usernames.

References

https://otwarchive.atlassian.net/browse/AO3-6493

tickinginstant and others added 3 commits July 9, 2023 14:25
@tickinginstant
Switch admin user search over to ES.
dc70fca 
Also adds an option to search past usernames and emails, available only
to superadmins, policy_and_abuse admins, and support admins.
@weeklies
Merge branch 'master' into AO3-6565
188506b
@weeklies
Fulfill new spec
a0526dd
sarken
sarken reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small front end comments -- feel free to lave them until further review is done!

app/views/admin/admin_users/show.html.erb Outdated Show resolved Hide resolved
app/views/admin/admin_users/index.html.erb Outdated Show resolved Hide resolved
@weeklies weeklies marked this pull request as ready for review August 14, 2024 17:51
brianjaustin
brianjaustin requested changes Dec 26, 2024
View reviewed changes
app/controllers/admin/admin_users_controller.rb Outdated Show resolved Hide resolved
config/locales/views/en.yml Outdated Show resolved Hide resolved
features/admins/users/admin_find_users.feature Outdated Show resolved Hide resolved
features/admins/users/admin_find_users.feature Outdated Show resolved Hide resolved
app/models/pseud.rb Outdated Show resolved Hide resolved
features/admins/users/admin_manage_users.feature Show resolved Hide resolved
features/admins/users/admin_find_users.feature Show resolved Hide resolved
@weeklies @brianjaustin
Apply suggestions from code review
984445e 
Co-authored-by: Brian Austin <13002992+brianjaustin@users.noreply.github.com>
@Bilka2
Copy link
Contributor

Bilka2 commented Jan 24, 2025

The checkbox escaped containment

Screenshot_20250124_215315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilka2 Bilka2 Bilka2 left review comments

@sarken sarken sarken left review comments

@brianjaustin brianjaustin brianjaustin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Coder Has Actioned Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weeklies @Bilka2 @sarken @brianjaustin @tickinginstant