[tools][server][tests] Check command parameters in handle content request payload #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 95.48% 95.56% +0.07%
==========================================
Files 236 236
Lines 26037 26527 +490
Branches 1827 1844 +17
==========================================
+ Hits 24862 25351 +489
- Misses 1175 1176 +1 |
NikitaZotov
added
bug
KovalM
approved these changes
Dec 17, 2024
...rver-impl/sc-memory-json/sc-memory-json-action/sc_memory_handle_link_content_json_action.hpp
Outdated
Show resolved
Hide resolved
NikitaZotov
force-pushed
the
fix/check_paramters_in_handle_content_commands
branch
from
05cf9d5 to
c433087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes core dumps that occurred when sending an invalid json like this:
{"id": 1, "type": "content", "payload": [{"command": "get", "data": 655546}]}
sc-machine: /usr/include/nlohmann/json.hpp:2144: const value_type& nlohmann::basic_json::operator const [with T = const char; ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector; nlohmann::basic_json::const_reference = const nlohmann::basic_json<>&]: Assertion `m_value.object->find(key) != m_value.object->end()' failed.
/home/crafting-bench/work/ostis-web-platform/sc-machine/scripts/run_sc_machine.sh: line 10: 32809 Aborted (core dumped) "${BINARY_PATH}/sc-machine" -c "${CONFIG_PATH}" "$@"