Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: Should keep connection when unpublishing. When the streaming is disconnected, FLV playback is also stopped, while RTMP continues playing, resulting in inconsistent behavior. #3000

Open
jinleileiking opened this issue Apr 11, 2022 · 4 comments
Open

HTTP: Should keep connection when unpublishing. When the streaming is disconnected, FLV playback is also stopped, while RTMP continues playing, resulting in inconsistent behavior. #3000

jinleileiking opened this issue Apr 11, 2022 · 4 comments
Assignees
@winlinvip
Labels
good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.
Milestone
6.0

Comments

@jinleileiking
Copy link

jinleileiking commented Apr 11, 2022 •
edited by winlinvip
Loading

The current logic I see is to wait for the client to disconnect the RTMP streaming link. The logic for HTTP-FLV is for the SRS server to actively disconnect. Can we make this consistent?

image

In FLV streaming, this feature exists, but it is not available in RTMP streaming.

TRANS_BY_GPT3
@najsword

This comment was marked as off-topic.

Sign in to view
@najsword

This comment was marked as off-topic.

Sign in to view
@winlinvip winlinvip changed the title rtmp推流，rtmp拉流同一条流，非集群模式， 如果推流断了，rtmp拉流是否要自动发起server close？ 推流断开时，FLV断开播放，RTMP保持播放，行为不一致 Apr 29, 2022
@winlinvip
Copy link
Member

winlinvip commented Apr 29, 2022 •
edited
Loading

This is a problem that should be consistent.

If there is no disconnection, the client will not be aware when the anchor starts streaming again, which provides a better user experience.

However, FLV is difficult to maintain because it requires deleting the HTTP mount.

Of course, sometimes RTMP also needs to be disconnected in order to save resources.

So I think the better solution is: when RTMP configuration is disconnected for streaming, whether to also disconnect the playback, the default is to not disconnect and keep it consistent with the current situation.

I have marked this issue as good first issue, and everyone is welcome to provide a patch.

TRANS_BY_GPT3

@winlinvip winlinvip self-assigned this Apr 29, 2022
@winlinvip winlinvip added the good first issue Easy to fix issues, good for newcomers label Apr 29, 2022
@winlinvip winlinvip added this to the 5.0 milestone Apr 29, 2022
@tangrufeng
Copy link

tangrufeng commented Jul 25, 2022 •
edited by winlinvip
Loading

This is a problem, it should be consistent.

If there is no disconnection, the client will not be aware when the anchor starts streaming again, which provides a better user experience.

However, FLV is difficult to maintain because it requires deleting the HTTP mount.

Of course, sometimes RTMP also needs to be disconnected in order to save resources.

So I think the better solution is: when RTMP configuration is disconnected for streaming, whether to also disconnect for playback, the default is to not disconnect and keep it consistent with the current setting.

I have marked this issue as good first issue, and everyone is welcome to provide patches.

Yes, I also expect that the streaming end can be disconnected while the HTTP end remains in a normal connected state, instead of EOF.

TRANS_BY_GPT3

@winlinvip winlinvip added the help wanted Extra attention is needed label Dec 25, 2022
@winlinvip winlinvip changed the title 推流断开时，FLV断开播放，RTMP保持播放，行为不一致 HTTP: Should keep connection when unpublishing. 推流断开时，FLV断开播放，RTMP保持播放，行为不一致 Jan 2, 2023
@winlinvip winlinvip modified the milestones: 5.0, 6.0 Jan 2, 2023
@winlinvip winlinvip changed the title HTTP: Should keep connection when unpublishing. 推流断开时，FLV断开播放，RTMP保持播放，行为不一致 HTTP: Should keep connection when unpublishing. When the streaming is disconnected, FLV playback is also stopped, while RTMP continues playing, resulting in inconsistent behavior. Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
4 participants
@jinleileiking @winlinvip @tangrufeng @najsword