Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Review and update CONTRIBUTING.md #4002

Merged
merged 10 commits into from
Apr 4, 2024
Merged

📖 Review and update CONTRIBUTING.md #4002

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99c0e36
feature dco requirement more prominently
spencerschrock Apr 3, 2024
b123cbd
recommend merge commits to sync PR
spencerschrock Apr 3, 2024
0ad51cd
fix make target table
spencerschrock Apr 3, 2024
12867ac
remove references to old Go environment variables
spencerschrock Apr 3, 2024
be7a687
misc minor clarifications
spencerschrock Apr 3, 2024
5a2dc9e
remove reference to errors from CONTRIBUTORS.md
spencerschrock Apr 3, 2024
b792ee1
mention make in environment
spencerschrock Apr 4, 2024
e888c13
no scopes needed for PATs
spencerschrock Apr 4, 2024
deacac2
highlight other scorecard options
spencerschrock Apr 4, 2024
0dca25e
allow shell codeblocks to be pasted into a shell
spencerschrock Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
recommend merge commits to sync PR 
Signed-off-by: Spencer Schrock <sschrock@google.com>
  • Loading branch information
@spencerschrock
spencerschrock committed Apr 3, 2024
commit b123cbd78d8afe24e8d658e7af231af3fc5d64aa
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,10 @@ assumed to match the PR. For instance, if you have a bugfix in with a breaking
change, it's generally encouraged to submit the bugfix separately, but if you
must put them in one PR, you should mark the whole PR as breaking.

When a maintainer reviews your code, it is generally preferred to solve each individual
review with small fixes without rebasing, so the maintainer can assess each fix separately.
> [!NOTE]
> Once a maintainer reviews your code, please address feedback without rebasing when possible.
> This includes [synchronizing your PR](https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch)
> with `main`. The GitHub review experience is much nicer with traditional merge commits.

## What to do before submitting a pull request

Expand Down