Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ignore unpinned dependencies in Dockerfiles in vendored directories #3675

Merged
merged 2 commits into from
Nov 16, 2023
+124 −11
Merged

🐛 Ignore unpinned dependencies in Dockerfiles in vendored directories #3675

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b59f3
:bug: Ignore unpinned dependencies in Dockerfiles in vendored directo…
AdamKorcz Nov 14, 2023
0310029
remove unnecessary check
AdamKorcz Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unnecessary check 
Signed-off-by: AdamKorcz <adam@adalogics.com>
  • Loading branch information
@AdamKorcz
AdamKorcz committed Nov 16, 2023
commit 0310029e6ad492e91545f34f815ea9fe9583e137
6 changes: 0 additions & 6 deletions checks/raw/pinned_dependencies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@
cleanedPath := filepath.Clean(pathfn)
splitCleanedPath := strings.Split(cleanedPath, "/")

// If the project vendors, this is likely to be how
// they do it. Therefore, check the first index
// before looping.
if splitCleanedPath[0] == "vendor" {
return true
}
for _, d := range splitCleanedPath {
if strings.EqualFold(d, "vendor") {
return true
Expand All @@ -145,8 +139,8 @@
}

if fileIsInVendorDir(pathfn) {
return true, nil
}

Check warning on line 143 in checks/raw/pinned_dependencies.go

View check run for this annotation

Codecov / codecov/patch

checks/raw/pinned_dependencies.go#L142-L143 

Added lines #L142 - L143 were not covered by tests

pdata := dataAsPinnedDependenciesPointer(args[0])

Expand Down
Loading