Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Improve flaky python test handling #6654

Merged
merged 1 commit into from
Sep 19, 2020
Merged

tests: Improve flaky python test handling #6654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tools/tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,11 +565,11 @@ def flaky(gen):
exceptions = []
def attempt(this):
try:
worked = gen(this)
gen(this)
return True
except Exception as e:
import traceback
exc_type, exc_obj, tb = sys.exc_info()
_, _, tb = sys.exc_info()
exceptions.append(e)
print(traceback.format_tb(tb)[1])
return False
Expand All @@ -578,6 +578,9 @@ def wrapper(this):
for i in range(3):
if attempt(this):
return True
# The attempt failed, try to setup again.
this.tearDown()
this.setUp()
i = 1
for exc in exceptions:
print("Test (attempt %d) %s::%s failed: %s" %
Expand Down