Eventing framework refactor #6610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrogario
added
the
events
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
from
648e889 to
0a45e69
Compare
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
4 times, most recently
from
589b974 to
88755c3
Compare
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
9 times, most recently
from
334ae14 to
85b1460
Compare
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
4 times, most recently
from
03c047c to
48446fe
Compare
alessandrogario
added
the
ready for review
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
from
48446fe to
a1ba8da
Compare
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
from
a1ba8da to
eefc466
Compare
theopolis
requested changes
Dec 5, 2020
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
4 times, most recently
from
a91d4c7 to
d212293
Compare
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
from
d212293 to
4616948
Compare
theopolis
requested changes
Dec 13, 2020
| [[deprecated("Group events together and use addBatch() instead.")]] | ||
| // clang-format on | ||
| Status | ||
| add(const Row& r); |
There was a problem hiding this comment.
nitpick, remove the newline within the function signature
There was a problem hiding this comment.
I tried to remove this newline but clang-format/make format will restore it, probably due to how the [[deprecated]] tag is handled
alessandrogario
force-pushed
the
alessandro/misc/eventing-framework-refactor
branch
from
4616948 to
53281b3
Compare
theopolis
approved these changes
Dec 18, 2020
mike-myers-tob
deleted the
alessandro/misc/eventing-framework-refactor
branch
mike-myers-tob
removed
the
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to move the event indexes outside the database to reduce the disk activity required to capture/evict/expire/return events.
A refactor has also taken place so that tests for this part of the code can be rewritten and improved to make sure regressions are not introduced.
Requires: #6732 (which is now done)