Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some code smells. #180

Merged
merged 11 commits into from
Jul 25, 2018
Merged

Fixed some code smells. #180

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
92e500f
Location: changed Double.valueOf to Double.parseDouble
lucaspcram Jul 19, 2018
bc35e7b
MultiPolygon: removed some unnecessary curly braces/return statement …
lucaspcram Jul 19, 2018
d32b254
MultiPolygon: replaced lambda with method reference in bounds function
lucaspcram Jul 19, 2018
f09a329
MultiPolygon: removed redundant continue statement in fullyGeometrica…
lucaspcram Jul 19, 2018
4a99869
Polygon: merged nested if statements in isApproximatelyNSided
lucaspcram Jul 19, 2018
4299560
Polygon: merged if statement with enclosing one in overlapsInternal()
lucaspcram Jul 19, 2018
3c3c2c9
AtlasFindEntitiesByIdSubCommand: changed printf to println
lucaspcram Jul 19, 2018
284a790
AtlasResourceLoaderErrorSubCommand: removed extra curly braces
lucaspcram Jul 19, 2018
5143789
Applied spotless
lucaspcram Jul 19, 2018
245c40d
Added explicit exception to Location forString
lucaspcram Jul 20, 2018
0d0720f
Addressed PR comment change in AtlasResourceLoaderErrorSubCommand
lucaspcram Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AtlasResourceLoaderErrorSubCommand: removed extra curly braces
  • Loading branch information
@lucaspcram
lucaspcram committed Jul 19, 2018
commit 284a790fb829840281e0ea85001b17da51abb04f
5 changes: 1 addition & 4 deletions ...a/org/openstreetmap/atlas/geography/atlas/command/AtlasResourceLoaderErrorSubCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ public int execute(final CommandMap map)
{
oops.printStackTrace();
ExceptionSearch.find(StreamCorruptedException.class).within(oops)
.ifPresent(poorlyFormattedFile ->
{
poorlyFormattedFile.printStackTrace();
});
.ifPresent(poorlyFormattedFile -> poorlyFormattedFile.printStackTrace());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The continue with the nice style @mgcuthbert referred to above, what about

.ifPresent(StreamCorruptedException::printStackTrace);

}
return 0;
}
Expand Down