I've rebased the changes now that #4450 is merged.

@benlorenz: I also had to add an Base.keys(::EdgeIterator) to the combinatorics part to make edges(::Graph) work with findall, e.g.,

G = vertex_edge_graph(simplex(3))
findall(edge->(1 in edge),edges(G))

Let me know if there are any objections. (I normally try to have separate pull-requests for separate areas, but was too lazy to make this one-line change)

Adding keys would imply that eit[i] should work but that is not the case and would be difficult to make work. Also the length (and thus the new keys function) will change during iteration since the EdgeIterator is stateful.

julia> eit = edges(g)
Oscar.EdgeIterator(Polymake.LibPolymake.GraphEdgeIteratorAllocated{Undirected}(Ptr{Nothing} @0x000000003f407670), 6)

julia> length(eit)
6

julia> iterate(eit)
(Edge(2, 1), 2)

julia> iterate(eit)
(Edge(3, 1), 2)

julia> length(eit)
4

julia> collect(eit)
4-element Vector{Edge}:
 Edge(3, 2)
 Edge(4, 1)
 Edge(4, 2)
 Edge(4, 3)

Adding keys would imply that eit[i] should work but that is not the case and would be difficult to make work. Also the length (and thus the new keys function) will change during iteration since the EdgeIterator is stateful.

Okay, I will remove Base.keys(::EdgeIterators) then and use collect(edges(G)) in findall.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (7219bae) to head (50280d3).
Report is 2 commits behind head on master.

@@           Coverage Diff           @@
##           master    #4452   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         668      669    +1     
  Lines       88441    88457   +16     
=======================================
+ Hits        74656    74672   +16     
  Misses      13785    13785