Include AA's conformance tests in all files that use them #4439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4439 +/- ##
=======================================
Coverage 84.39% 84.39%
=======================================
Files 663 663
Lines 87938 87938
=======================================
Hits 74214 74214
Misses 13724 13724 |
There was a problem hiding this comment.
At least for some of the test folders it would be nicer to have this in a setup_tests.jl, for example in test/LieTheory there is already a setup file which includes the Rings-conformance-tests.jl.
For test/Rings it would also avoid quite a bit of duplication.
test_module should load these files automatically if they exist.
Maybe we can even remove the @everywhere include for this file then?
lgoettgens
force-pushed
the
lg/inlcude-conformance-tests
branch
from
12a407f to
7649384
Compare
|
Done. I wouldn't spend any more work on the details here, since I am already working on a version of Nemocas/AbstractAlgebra.jl#1936 that works even in julia 1.6, so we can hopefully remove all of this in the near future. |
Thanks to @paemurru for reporting on slack.
Even though we have
Oscar.jl/test/runtests.jl
Lines 53 to 54 in 3505630
Oscar.test_module. Thus the easiest fix is to explicitly include this file at these few positions.In the long run, this will become obsolete by Nemocas/AbstractAlgebra.jl#1936.