Popup fix: Property 'transitionEnd' is never assigned, so banner doesn't set display to 'none' after it fades + broken unit test #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transitionEnd
property is never assigned when checking the compatibie transition class meaning that the correcttransitionEnd
event is never listened to, meaning thatdisplay: none
never gets set after the popup fades, so the popup window, in the case of revocable popups, when faded will still occlude elements on the page.Also fixed broken unit test, the 'updates
content
optionslink
andmessagelink
' test fails when running Jest, this is due to theregionalLaw
property being missing on the passed inoptions
, but also missed on thedefault
object, meaning that it never gets merged, so the property will always beundefined
- even when set on theoptions
object.