Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stricter JSON patch checking for PATCH identities #4263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: stricter JSON patch checking for PATCH identities #4263

wants to merge 2 commits into from
+55 −2

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jan 6, 2025

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Jan 6, 2025
@hperl hperl requested review from aeneasr and a team as code owners January 6, 2025 14:02
@hperl hperl force-pushed the hperl/fix-patch-identity-credentials branch from 26e0e13 to 92d6180 Compare January 6, 2025 14:05
jonas-jonas
jonas-jonas approved these changes Jan 6, 2025
View reviewed changes
identity/handler.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.58%. Comparing base (23f3232) to head (4134830).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4263      +/-   ##
==========================================
- Coverage   78.61%   78.58%   -0.03%     
==========================================
  Files         381      381              
  Lines       27385    27385              
==========================================
- Hits        21528    21520       -8     
- Misses       4237     4241       +4     
- Partials     1620     1624       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl enabled auto-merge (squash) January 7, 2025 12:20
jonas-jonas
jonas-jonas approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-jonas jonas-jonas jonas-jonas approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees

@hperl hperl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hperl @jonas-jonas