Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly pass multiple token audiences and prompt parameters wh… #3736

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: correctly pass multiple token audiences and prompt parameters wh… #3736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: correctly pass multiple token audiences and prompt parameters wh… 
…en performing the authorization code flow from the CLI
  • Loading branch information
@alnr
alnr committed Mar 14, 2024
commit 6266558c43fb89c0f097f701e71ec13c6d798f77
4 changes: 2 additions & 2 deletions cmd/cmd_perform_authorization_code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@

authCodeURL := conf.AuthCodeURL(
state,
oauth2.SetAuthURLParam("audience", strings.Join(audience, "+")),
oauth2.SetAuthURLParam("audience", strings.Join(audience, " ")),

Check warning on line 155 in cmd/cmd_perform_authorization_code.go

View check run for this annotation

Codecov / codecov/patch

cmd/cmd_perform_authorization_code.go#L155 

Added line #L155 was not covered by tests
oauth2.SetAuthURLParam("nonce", string(nonce)),
oauth2.SetAuthURLParam("prompt", strings.Join(prompt, "+")),
oauth2.SetAuthURLParam("prompt", strings.Join(prompt, " ")),

Check warning on line 157 in cmd/cmd_perform_authorization_code.go

View check run for this annotation

Codecov / codecov/patch

cmd/cmd_perform_authorization_code.go#L157 

Added line #L157 was not covered by tests
oauth2.SetAuthURLParam("max_age", strconv.Itoa(maxAge)),
)
return authCodeURL, state
Expand Down
Loading