fix: Backchannel Logout: Fix error log when RP responds with status code 204 #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiebelsTim
force-pushed
the
fix-backchannel-status-204
branch
from
7eb5f01 to
cb95f3e
Compare
aeneasr
approved these changes
Mar 6, 2024
SiebelsTim
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3731 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 134 134
Lines 10214 10214
=======================================
Hits 7793 7793
Misses 1904 1904
Partials 517 517 ☔ View full report in Codecov by Sentry. |
…ode 204 According to the specification at https://openid.net/specs/openid-connect-backchannel-1_0.html#BCResponse the Relying Party must respond with a status code 200. However, it also notes that the OpenID Provider should be prepared to handle status code 204 (No Content) as a successful response as well.
SiebelsTim
force-pushed
the
fix-backchannel-status-204
branch
from
cb95f3e to
69cd817
Compare
hperl
approved these changes
Mar 7, 2024
|
I am happy that the changes were approved so quickly. Do I need to do anything else? |
|
Me clicking merge, sorry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification at https://openid.net/specs/openid-connect-backchannel-1_0.html#BCResponse the Relying Party must respond with a status code 200. However, it also notes that the OpenID Provider should be prepared to handle status code 204 (No Content) as a successful response as well.
Related issue(s)
This is a previously unknown bug.
Reproduction:
Note that this does not change any behaviour. The logged error does not have an influence whether the user is logged out or not.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works. -- Since this is only related to logging. Adding a test is difficult for me.
Further Comments