Add wait event for wal group flush

Add wait event for wal group flush

Skip not SOAP-supported indexes while transforming an OR clause into …

…SAOP

There is no point in transforming OR-clauses into SAOP's if the target index
doesn't support SAOP scans anyway.  This commit adds corresponding checks
to match_orclause_to_indexcol() and group_similar_or_args().  The first check
fixes the actual bug, while the second just saves some cycles.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/8174de69-9e1a-0827-0e81-ef97f56a5939%40gmail.com
Author: Alena Rybakina
Reviewed-by: Ranier Vilela, Alexander Korotkov

Skip not SOAP-supported indexes while transforming an OR clause into …

…SAOP

There is no point in transforming OR-clauses into SAOP's if the target index
doesn't support SAOP scans anyway.  This commit adds corresponding checks
to match_orclause_to_indexcol() and group_similar_or_args().  The first check
fixes the actual bug, while the second just saves some cycles.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/8174de69-9e1a-0827-0e81-ef97f56a5939%40gmail.com
Author: Alena Rybakina
Reviewed-by: Ranier Vilela, Alexander Korotkov

Stabilize jsonb_path_query test case.

An operation like '12:34:56'::time_tz takes the UTC offset from
the prevailing time zone, which means that the results change
across DST transitions.  One of the test cases added in ed055d249
failed to consider this.

Per report from Bernhard Wiedemann.  Back-patch to v17, as the
test case was.

Discussion: https://postgr.es/m/ba8e1bc0-8a99-45b7-8397-3f2e94415e03@suse.de

Teach bitmap path generation about transforming OR-clauses to SAOP's

When optimizer generates bitmap paths, it considers breaking OR-clause
arguments one-by-one.  But now, a group of similar OR-clauses can be
transformed into SAOP during index matching.  So, bitmap paths should
keep up.

This commit teaches bitmap paths generation machinery to group similar
OR-clauses into dedicated RestrictInfos.  Those RestrictInfos are considered
both to match index as a whole (as SAOP), or to match as a set of individual
OR-clause argument one-by-one (the old way).

Therefore, bitmap path generation will takes advantage of OR-clauses to SAOP's
transformation.  The old way of handling them is also considered.  So, there
shouldn't be planning regression.

Discussion: https://postgr.es/m/567ED6CA.2040504%40sigaev.ru
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>

Fix active snapshot checks

Revert pre 5bf748b SAOP behavior in PG17

Commit 5bf748b allows generation of unsafe SAOP path keys
on a multicolumn index that were disabled previously by 807a40c.

Fix warning in pg_rewind

Make index insert compatible with outside callers

We split aminsert method to aminsert and aminsertextended.

aminsert is a method for indexes implemented in other extensions, it
accepts ItemPointer tupleid.

aminsertextended is for internal Postgres indexes and Orioledb, it
accepts Datum tupleid. They are not supposed to call aminsert method, so
that it is set NULL for them. We can not rely that extensions are aware
of aminsertextended, so index_insert() calls aminsert if it's not NULL
preferentially.

Signature of index_insert() is reverted so that it could be called by other
extensions. Datum tupleid is confined inside index_insert method.