Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): fall back to org-id search ID face computation #1195

Merged
merged 2 commits into from
Oct 19, 2020
Merged

(fix): fall back to org-id search ID face computation #1195

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637af53
(fix): fall back to org-id search ID face computation
jethrokuan Oct 19, 2020
497a41f
Document faces, default to only applying to Org-roam notes
jethrokuan Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(fix): fall back to org-id search ID face computation 
Fixes the scenario where the face is reported as invalid although it is
part of Org's ID files (e.g. in the agenda).

Fixes #1191.

This can however slow face computation a lot (when there are many org
id/agenda files). Here, we choose to focus on correctness.
  • Loading branch information
@jethrokuan
jethrokuan committed Oct 19, 2020
commit 637af53d9a4d62b1bea2089a38be969677b0bfd7
3 changes: 2 additions & 1 deletion org-roam.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,8 @@ file."
(custom (or (and in-note org-roam-link-use-custom-faces)
(eq org-roam-link-use-custom-faces 'everywhere))))
(cond ((and custom
(not (org-roam-id-get-file id)))
(not (org-roam-id-get-file id))
(not (org-id-find id)))
'org-roam-link-invalid)
((and (org-roam--in-buffer-p)
(org-roam--backlink-to-current-p))
Expand Down