Fixes #4294 : Added Profile delete message with AlertDialog #5577

theayushyadav11 · 2024-11-16T19:31:30Z

Fixes #4294 : This pull request introduces a new feature to notify users when a profile is successfully deleted. It includes the creation of a new dialog fragment, updates to existing fragments to integrate this new feature, and necessary string resources.

New Feature Implementation:

app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt: Created a new DeleteProfileSuccessDialogFragment class to notify users after a profile is successfully deleted.

Integration with Existing Components:

app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt: Added import and injection for DeleteProfileSuccessDialogFragment. [1] [2]
app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt: Updated to show the new DeleteProfileSuccessDialogFragment upon successful profile deletion.

String Resources:

app/src/main/res/values/strings.xml: Added a new string resource for the profile deletion success message.

Test File Exemptions:

scripts/assets/test_file_exemptions.textproto: Added an exemption for the new ProfileDeleteSuccessDialogFragment.

Video Demo

TalkBackRecording.mp4

Video Demo on Tablet

Running.Devices.-.oppia-android.2024-11-21.00-59-00.mp4

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

theayushyadav11 · 2024-11-16T21:04:28Z

@adhiamboperes PTAL.

theayushyadav11 · 2024-11-19T04:49:53Z

Hey @adhiamboperes,
Could you please review my updates and let me know if any adjustments are needed? Thank you for your guidance!

github-actions · 2024-11-20T04:18:48Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 28 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 19 KiB (Removed)

Method count: 259595 (old), 259201 (new), 394 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6809 (new), 7 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1272 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 378 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 849 (new), 1 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
- string/profile_edit_delete_successful_message (added)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 28 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 22 KiB (Removed)
Method count: 259595 (old), 259201 (new), 394 (Removed)
Resources: 6766 (old), 6759 (new), 7 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)
Id: 1275 (old), 1272 (new), 3 (Removed)
Layout: 380 (old), 378 (new), 2 (Removed)
String: 850 (old), 849 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 20 KiB (Removed)

Method count: 116054 (old), 115738 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5777 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 782 (new), 1 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 23 KiB (Removed)
Method count: 116054 (old), 115738 (new), 316 (Removed)
Resources: 5741 (old), 5734 (new), 7 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 782 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 28 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Removed)

Method count: 116060 (old), 115744 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5777 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 782 (new), 1 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 28 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 20 KiB (Removed)
Method count: 116060 (old), 115744 (new), 316 (Removed)
Resources: 5741 (old), 5734 (new), 7 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 782 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 28 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Removed)

Method count: 116060 (old), 115744 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5777 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 782 (new), 1 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 28 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 20 KiB (Removed)
Method count: 116060 (old), 115744 (new), 316 (Removed)
Resources: 5741 (old), 5734 (new), 7 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 782 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @theayushyadav11!

I have left some suggestions. PTAL.

Also please add a tablet screen recording(without talkback), since tablet behaviour is also affected.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

theayushyadav11 · 2024-11-20T19:38:12Z

Thank you so much for your detailed review, @adhiamboperes. I’ve worked on addressing all the comments in my recent commit. If there are any areas that still need improvement, I’d be grateful if you could guide me further. Looking forward to your feedback!

Video Demo on Tablet

Running.Devices.-.oppia-android.2024-11-21.00-59-00.mp4

theayushyadav11 · 2024-11-21T06:29:59Z

Hey @adhiamboperes PTAL.

oppiabot · 2024-11-21T06:33:05Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

TanishMoral11 · 2024-11-22T08:16:09Z

I would like to suggest changing the text color of 'Delete' to red ( same as Profile Deletion ) so that it looks more visually appealing.

github-actions · 2024-11-23T04:20:02Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 28 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 21 KiB (Removed)

Method count: 259595 (old), 259201 (new), 394 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6810 (new), 6 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1272 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 378 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 28 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 23 KiB (Removed)
Method count: 259595 (old), 259201 (new), 394 (Removed)
Resources: 6766 (old), 6760 (new), 6 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)
Id: 1275 (old), 1272 (new), 3 (Removed)
Layout: 380 (old), 378 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 19 KiB (Removed)

Method count: 116054 (old), 115738 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5778 (new), 6 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 23 KiB (Removed)
Method count: 116054 (old), 115738 (new), 316 (Removed)
Resources: 5741 (old), 5735 (new), 6 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 28 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 26 KiB (Removed)

Method count: 116060 (old), 115744 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5778 (new), 6 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 22 KiB (Removed)
Method count: 116060 (old), 115744 (new), 316 (Removed)
Resources: 5741 (old), 5735 (new), 6 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Removed)

Method count: 116060 (old), 115744 (new), 316 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5778 (new), 6 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 20 KiB (Removed)
Method count: 116060 (old), 115744 (new), 316 (Removed)
Resources: 5741 (old), 5735 (new), 6 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-11-26T01:32:28Z

Thanks @theayushyadav11!

Could you please check that the tests pass?

org.oppia.android.app.settings.profile.ProfileEditFragmentTest > testProfileEdit_startWithUserProfile_clickDelete_configChange_checkOpensDeletionDialog_checkOpensSuccessDialogIsVisible FAILED
    androidx.test.espresso.NoMatchingRootException: Matcher 'is dialog' did not match any of the following roots: [Root{application-window-token=android.view.ViewRootImpl$W@771eb3f3, window-token=android.view.ViewRootImpl$W@771eb3f3, has-window-focus=true, layout-params-type=1, layout-params-string={(0,0)(fillxfill) ty=BASE_APPLICATION wanim=0x7f120005
      fl=LAYOUT_IN_SCREEN LAYOUT_INSET_DECOR SPLIT_TOUCH HARDWARE_ACCELERATED DRAWS_SYSTEM_BAR_BACKGROUNDS
      pfl=FORCE_DRAW_STATUS_BAR_BACKGROUND FIT_INSETS_CONTROLLED
      fitSides=}, decor-view-string=DecorView{id=-1, visibility=VISIBLE, width=470, height=320, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params={(0,0)(fillxfill) ty=BASE_APPLICATION wanim=0x7f120005
      fl=LAYOUT_IN_SCREEN LAYOUT_INSET_DECOR SPLIT_TOUCH HARDWARE_ACCELERATED DRAWS_SYSTEM_BAR_BACKGROUNDS
      pfl=FORCE_DRAW_STATUS_BAR_BACKGROUND FIT_INSETS_CONTROLLED
      fitSides=}, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}}]

github-actions · 2024-11-30T09:20:19Z

Coverage Report

Results

Number of files assessed: 5
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileDeleteSuccessDialogFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditFragmentPresenter.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FragmentComponentImpl.kt app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-12-01T04:02:19Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 1172 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 928 bytes (Added)

Method count: 260158 (old), 260184 (new), 26 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6818 (new), 2 (Added)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 852 (new), 2 (Added):
- string/profile_edit_delete_success_dialog_positive_button (added)
- string/profile_edit_delete_successful_message (added)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 1168 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 697 bytes (Added)
Method count: 260158 (old), 260184 (new), 26 (Added)
Resources: 6766 (old), 6768 (new), 2 (Added)

String: 850 (old), 852 (new), 2 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 464 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1544 bytes (Added)

Method count: 116247 (old), 116262 (new), 15 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5786 (new), 2 (Added)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 785 (new), 2 (Added):
- string/profile_edit_delete_success_dialog_positive_button (added)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 468 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 186 bytes (Added)
Method count: 116247 (old), 116262 (new), 15 (Added)
Resources: 5741 (old), 5743 (new), 2 (Added)

String: 783 (old), 785 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 616 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 283 bytes (Removed)

Method count: 116253 (old), 116268 (new), 15 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5786 (new), 2 (Added)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 785 (new), 2 (Added):
- string/profile_edit_delete_success_dialog_positive_button (added)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 616 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 1053 bytes (Removed)
Method count: 116253 (old), 116268 (new), 15 (Added)
Resources: 5741 (old), 5743 (new), 2 (Added)

String: 783 (old), 785 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 648 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 91 bytes (Removed)

Method count: 116253 (old), 116268 (new), 15 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5786 (new), 2 (Added)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 785 (new), 2 (Added):
- string/profile_edit_delete_success_dialog_positive_button (added)
- string/profile_edit_delete_successful_message (added)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 652 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 220 bytes (Added)
Method count: 116253 (old), 116268 (new), 15 (Added)
Resources: 5741 (old), 5743 (new), 2 (Added)

String: 783 (old), 785 (new), 2 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @theayushyadav11! Nice work on this PR.

There are some ktlin failures preventing merge, and I have added some suggestions on how to fix them. PTAL.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt

app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditFragmentTest.kt

…ete-profile-message

github-actions · 2024-12-02T14:58:39Z

Coverage Report

Results

Number of files assessed: 5
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileDeleteSuccessDialogFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditFragmentPresenter.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FragmentComponentImpl.kt app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-12-02T17:35:24Z

Coverage Report

Results

Number of files assessed: 5
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileDeleteSuccessDialogFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditFragmentPresenter.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FragmentComponentImpl.kt app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

theayushyadav11 · 2024-12-02T18:17:04Z

Thanks @adhiamboperes ,PTAL
Can You please suggest me a better way to check Ktlint errors because the command java -jar /home/runner/oppia-android-tools/ktlint -F --android domain/src/**/*.kt utility/src/**/*.kt data/src/**/*.kt app/src/**/*.kt testing/src/**/*.kt scripts/src/**/*.kt instrumentation/src/**/*.kt. shows "cannot access jar file error" and I have to manually check for it.

oppiabot · 2024-12-02T18:20:09Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @theayushyadav11! This LGTM.

adhiamboperes · 2024-12-03T00:47:35Z

@theayushyadav11, you may be experiencing the jar error because your ktlint was not properly set up. Please re-run bash scripts/setup.sh. You should see the message, "Ktlint file downloaded."

oppiabot · 2024-12-03T00:47:57Z

Unassigning @adhiamboperes since they have already approved the PR.

oppiabot · 2024-12-03T00:48:00Z

Assigning @BenHenning for code owner reviews. Thanks!

github-actions · 2024-12-03T01:30:47Z

👏 Well done @theayushyadav11! Two PRs merged already! 🎉🥳

With your second PR, you're on a roll, and your contributions are already making a difference. 🌟
This means you may be eligible to join the Oppia dev team as a collaborator! 🎉 If you're interested, please fill out this form and become an even more integral part of the community. 🌱

Looking forward to seeing even more contributions from you. The developer onboarding lead: @adhiamboperes is here if you need any help! Keep up the great work! 🚀

github-actions · 2024-12-03T01:30:51Z

Coverage Report

Results

Number of files assessed: 5
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileDeleteSuccessDialogFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileDeleteSuccessDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileEditFragmentPresenter.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FragmentComponentImpl.kt app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Added Profile delete message with AlertDialog

caa9a0c

theayushyadav11 requested review from a team as code owners November 16, 2024 19:31

theayushyadav11 requested a review from BenHenning November 16, 2024 19:31

theayushyadav11 added 6 commits November 17, 2024 01:15

Fixed naming

fce2558

removed and added newline

6aba26c

removed ktlint

e23699c

removed spacing and unused import

785f751

changed name

ad6a8e1

changed name

6ecf257

oppiabot bot assigned adhiamboperes Nov 16, 2024

adhiamboperes requested changes Nov 20, 2024

View reviewed changes

adhiamboperes assigned theayushyadav11 and unassigned adhiamboperes Nov 20, 2024

Added test

1b19183

fixed tests

7224157

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Nov 21, 2024

adhiamboperes assigned theayushyadav11 and unassigned adhiamboperes Nov 26, 2024

Merge branch 'develop' into delete-profile-message

307b031

adhiamboperes requested changes Dec 2, 2024

View reviewed changes

adhiamboperes assigned theayushyadav11 and unassigned adhiamboperes Dec 2, 2024

theayushyadav11 added 2 commits December 2, 2024 19:19

Reformated files

ee5cffe

Merge remote-tracking branch 'origin/delete-profile-message' into del…

346bd59

…ete-profile-message

theayushyadav11 added 3 commits December 2, 2024 22:02

Reformated files

db7df6b

Reformated files

875edb3

Reformated files

28030ec

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Dec 2, 2024

adhiamboperes approved these changes Dec 3, 2024

View reviewed changes

Merge branch 'develop' into delete-profile-message

9b84046

oppiabot bot unassigned adhiamboperes Dec 3, 2024

oppiabot bot assigned BenHenning Dec 3, 2024

adhiamboperes enabled auto-merge (squash) December 3, 2024 00:48

adhiamboperes assigned theayushyadav11 and unassigned BenHenning Dec 3, 2024

adhiamboperes merged commit 242fef4 into oppia:develop Dec 3, 2024
43 checks passed

theayushyadav11 deleted the delete-profile-message branch December 3, 2024 06:09

Fixes #4294 : Added Profile delete message with AlertDialog #5577

Fixes #4294 : Added Profile delete message with AlertDialog #5577

Conversation

theayushyadav11 commented Nov 16, 2024 • edited by adhiamboperes Loading

New Feature Implementation:

Integration with Existing Components:

String Resources:

Test File Exemptions:

Video Demo

Video Demo on Tablet

Essential Checklist

theayushyadav11 commented Nov 16, 2024

theayushyadav11 commented Nov 19, 2024

github-actions bot commented Nov 20, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes left a comment

Choose a reason for hiding this comment

theayushyadav11 commented Nov 20, 2024 • edited Loading

Video Demo on Tablet

theayushyadav11 commented Nov 21, 2024

oppiabot bot commented Nov 21, 2024

TanishMoral11 commented Nov 22, 2024

github-actions bot commented Nov 23, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

theayushyadav11 commented Nov 16, 2024 •

edited by adhiamboperes

Loading

theayushyadav11 commented Nov 20, 2024 •

edited

Loading