Add tests for linters #4993
Labels
enhancement
End user-perceivable enhancements.
Impact: Low
Low perceived user impact (e.g. edge cases).
Work: High
It's not clear what the solution is.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Is your feature request related to a problem? Please describe.
#4983 introduced linter wrappers for multiple languages (to replace the existing shell scripts). These require unit tests for behavior regression verification.
Describe the solution you'd like
Each of the new, untested classes in the PR need tests to cover their main behaviors. Below are the new classes and minimum tests to add (more are likely needed, these are just a first pass):
Describe alternatives you've considered
N/A -- All utilities require tests.
Additional context
Each of the utilities above already have existing placeholder test suites that are ready for new tests to be added, and should already build, run, and pass.
All other script & script utility tests are good to reference when building these. Note that these tests can only be run with Bazel and syntax highlighting/auto completion won't work in Android Studio unless using the Bazel plugin.
Note also that these tests often require creating real test data (such as APKs) to verify their functionality. This should be done without needing to permanently check in any binary or test files to the repository (prefer generating the files at runtime during the test run, instead), aside from changing the existing test suite files.
The text was updated successfully, but these errors were encountered: