Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly enable warnings-as-errors for processor-generated Java code #4936

Open
BenHenning opened this issue Apr 1, 2023 · 0 comments
Open

Correctly enable warnings-as-errors for processor-generated Java code #4936

BenHenning opened this issue Apr 1, 2023 · 0 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Is your feature request related to a problem? Please describe.
As part of migrating to Kotlin 1.6 (#4120) the work includes enabling Kotlin's warnings-as-errors and fixing all warnings so that the app build can remain relatively clean long-term. For consistency. Javac's warnings-as-errors was also enabled, however neither setting extends to Java-generated code from a kapt-run processor (see bazelbuild/rules_kotlin#262 (comment)). Until that issue is fixed, we can't enable errors for generated processor code (such as Dagger).

Describe the solution you'd like
Warnings-as-errors should be enabled for all Java & Kotlin code, including for kapt processor-generated code.

Describe alternatives you've considered
The only feasible alternative is not enabling warnings-as-errors which isn't ideal.

Additional context
None.
@MohitGupta121 MohitGupta121 added Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged. enhancement End user-perceivable enhancements. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanlip @BenHenning @MohitGupta121