Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6158: Log for interpolate url issue #7952

Merged
merged 2 commits into from
Nov 10, 2019

Conversation

kevintab95
Copy link
Member

@kevintab95 kevintab95 commented Nov 9, 2019

Explanation

Fixes #6158: Adds a log for interpolateUrl issue.

Note: This error was fixed earlier in #7738. However, it re-occurred again with a different stacktrace. This seems to be a new scenario where it throws this error. We will need to rely on the additional logs to help with the fix.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@oppiabot
Copy link

oppiabot bot commented Nov 9, 2019

Hi, @kevintab95. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #7952 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #7952      +/-   ##
===========================================
- Coverage    83.97%   83.97%   -<.01%     
===========================================
  Files         1150     1150              
  Lines        68617    68621       +4     
  Branches      3913     3913              
===========================================
+ Hits         57621    57622       +1     
- Misses        9660     9663       +3     
  Partials      1336     1336
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.65% <0%> (ø) ⬇️
Impacted Files Coverage Δ
...directives/oppia-noninteractive-image.directive.ts 15% <0%> (-1.67%) ⬇️
...mplates/dev/head/services/id-generation.service.ts 100% <0%> (+16.67%) ⬆️

Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek merged commit 4fe6c61 into oppia:develop Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server error: Parameters passed into interpolateUrl must be strings
3 participants