Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

Merged
merged 6 commits into from
Nov 7, 2019
+8 −1
Merged

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7bfc56
issue #6482 fixed - Skill editor, Questions, button Save and Publish …
discombobulateme Nov 3, 2019
02dcb61
2 errors that appeared on push fixerd
discombobulateme Nov 3, 2019
5cfd3e0
max lenght error fixed
discombobulateme Nov 3, 2019
932ae56
space error fixed
discombobulateme Nov 3, 2019
022a2bb
function name corrected and tooltip added
discombobulateme Nov 4, 2019
06ee38f
merging develop
discombobulateme Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
2 errors that appeared on push fixerd
  • Loading branch information
@discombobulateme
discombobulateme committed Nov 3, 2019
commit 02dcb61493d4b577a5d8bf4e148b8ddd1fa07300
4 changes: 2 additions & 2 deletions ...plates/dev/head/components/question-directives/questions-list/questions-list.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,10 @@ angular.module('oppia').directive('questionsList', [
$uibModalInstance.close();
};
// Checking if Question contains all requirement to enable Save and Publish Question
$scope.toggleEnableButton = function(){
$scope.toggleEnableButton = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the function to something like isSaveButtonDisabled().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

return $scope.question.validate(
$scope.misconceptionsBySkill);
}
};

$scope.cancel = function() {
if (QuestionUndoRedoService.hasChanges()) {
Expand Down