Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split flag for new structure viewers #7898

Merged
merged 5 commits into from
Nov 5, 2019
Merged

Split flag for new structure viewers #7898

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fb7e5b
Split flag
aks681 Nov 2, 2019
113c8a7
added comment
aks681 Nov 2, 2019
66ceae9
fixed test
aks681 Nov 2, 2019
01df2db
Merge remote-tracking branch 'upstream/develop' into create-flag
aks681 Nov 2, 2019
c224a8d
Merge remote-tracking branch 'upstream/develop' into create-flag
aks681 Nov 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added comment
  • Loading branch information
@aks681
aks681 committed Nov 2, 2019
commit 113c8a7969ce005f07a661947dc85e88f52bd0de
6 changes: 6 additions & 0 deletions assets/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@ export = {

"ENABLE_PREREQUISITE_SKILLS": false,

// For the full new structures viewer features, both
// ENABLE_NEW_STRUCTURE_PLAYERS and ENABLE_NEW_STRUCTURE_VIEWER_UPDATES has
// to be true. Only ENABLE_NEW_STRUCTURE_PLAYERS can be true if just the
// players need to be accessed, but without story progress updation.
// This is split up so as to access the viewers in production without
// exposing the POST and PUT endpoints just yet.
"ENABLE_NEW_STRUCTURE_PLAYERS": false,

"ENABLE_NEW_STRUCTURE_VIEWER_UPDATES": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a comment explaining precisely what this controls, so that other devs don't use it beyond its intended purpose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Expand Down