Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6158: Initialise $interval inside initSession method #7738

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

kevintab95
Copy link
Member

Explanation

Fixes #6158: This PR moves $interval inside initSession to ensure the timer starts only after the session is initialised. (see this for more detailed explanation)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@DubeySandeep
Copy link
Member

@kevintab95, I'm not sure when we call initSession method but for me the general pattern of these changes in are good. I've assigned @brianrodri for a review I think he will be a better person to review this change. Thanks! :)

@DubeySandeep DubeySandeep requested review from brianrodri and removed request for DubeySandeep October 4, 2019 09:10
@DubeySandeep
Copy link
Member

@aks681, Can you please review this PR as a codeowner?

Copy link
Contributor

@brianrodri brianrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@DubeySandeep
Copy link
Member

@aks681, Can you please review this PR as a codeowner?

@aks681 aks681 merged commit 610e735 into oppia:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server error: Parameters passed into interpolateUrl must be strings
4 participants