Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7536: fa-times not loading correctly in the learner dashboard #7567

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Fix #7536: fa-times not loading correctly in the learner dashboard #7567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/templates/dev/head/pages/learner-dashboard-page/learner-dashboard-page.directive.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ <h1 class="stat-value"><[$ctrl.subscriptionsList.length]></h1>
<div ng-repeat="tile in $ctrl.incompleteExplorationsList | orderBy:$ctrl.getValueOfExplorationSortKey:$ctrl.isCurrentExpSortDescending | limitTo:$ctrl.PAGE_SIZE:$ctrl.startIncompleteExpIndex track by tile.id"
style="display: inline-block; margin-left: 1px;"
ng-mouseenter="showRemoveIcon=true" ng-mouseleave="showRemoveIcon=false">
<i class="remove-icon fab fa-times"
<i class="remove-icon fa fa-times"
ng-show="showRemoveIcon"
aria-hidden="true"
ng-click="$ctrl.openRemoveActivityModal($ctrl.activeSection, $ctrl.activeSubsection, tile)"
Expand Down Expand Up @@ -339,7 +339,7 @@ <h1 class="stat-value"><[$ctrl.subscriptionsList.length]></h1>
ng-repeat="tile in $ctrl.explorationPlaylist track by $index"
ng-mouseenter="showRemoveIcon=true" ng-mouseleave="showRemoveIcon=false"
style="height: 145px; display: block;">
<i class="remove-icon fab fa-times"
<i class="remove-icon fa fa-times"
ng-show="showRemoveIcon"
aria-hidden="true"
style="color: black;"
Expand Down Expand Up @@ -393,7 +393,7 @@ <h1 class="stat-value"><[$ctrl.subscriptionsList.length]></h1>
<div ng-repeat="tile in $ctrl.incompleteCollectionsList"
style="display: inline-block; margin-left: 1px;"
ng-mouseenter="showRemoveIcon=true" ng-mouseleave="showRemoveIcon=false">
<i class="remove-icon fab fa-times"
<i class="remove-icon fa fa-times"
ng-show="showRemoveIcon"
aria-hidden="true"
ng-click="$ctrl.openRemoveActivityModal($ctrl.activeSection, $ctrl.activeSubsection, tile)"
Expand Down Expand Up @@ -455,7 +455,7 @@ <h1 class="stat-value"><[$ctrl.subscriptionsList.length]></h1>
ng-repeat="tile in $ctrl.collectionPlaylist track by $index"
style="display: inline-block; margin-left: 1px; height: 145px;"
ng-mouseenter="showRemoveIcon=true" ng-mouseleave="showRemoveIcon=false">
<i class="remove-icon fab fa-times"
<i class="remove-icon fa fa-times"
ng-show="showRemoveIcon"
style="color: black;"
aria-hidden="true"
Expand Down