Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base controller from HTML tag to after Angular bootstrap and convert I18NFooter and Thanks to component directives. #7283

Merged
merged 15 commits into from
Aug 5, 2019
Merged

Remove base controller from HTML tag to after Angular bootstrap and convert I18NFooter and Thanks to component directives. #7283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8c5e12f
Fixed splash-at0 and splash-at1
YashJipkate Jul 5, 2019
213a31e
Thanks page to component directive
YashJipkate Jul 5, 2019
79ed17d
I18N Footer to component directive
YashJipkate Jul 5, 2019
c4cdb7f
Fix backend test
YashJipkate Jul 5, 2019
f571dce
Revert splash fix
YashJipkate Jul 6, 2019
938be07
Revert "Fix backend test"
YashJipkate Jul 5, 2019
ae0f02b
Revert package-lock
YashJipkate Jul 7, 2019
b300849
Incomplete work
YashJipkate Jul 7, 2019
80855bf
Merge
YashJipkate Jul 28, 2019
9af2703
Merge
YashJipkate Jul 28, 2019
6099a21
Merge
YashJipkate Aug 1, 2019
7da5599
Ready the base controller
YashJipkate Aug 1, 2019
ee88263
NIts
YashJipkate Aug 3, 2019
4b6d8a0
Merge branch 'develop' into splash-comp-dir
YashJipkate Aug 3, 2019
9dd2e6a
Update package-lock.json
YashJipkate Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NIts
  • Loading branch information
@YashJipkate
YashJipkate committed Aug 3, 2019
commit ee88263f7a00a55bce4071fd762f8fb7ee94ef81
2 changes: 1 addition & 1 deletion core/templates/dev/head/pages/Base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ require('services/contextual/UrlService.ts');
require('app.constants.ts');

/**
* @fileoverview Oppia's base directive.
* @fileoverview Oppia's base controller.
*/

angular.module('oppia').controller('Base', [
Expand Down
2 changes: 1 addition & 1 deletion core/templates/dev/head/pages/practice-session-page/practice-session-page.mainpage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html ng-app="oppia" lang="<[currentLang]>" itemscope itemtype="http://schema.org/Organization">
<html ng-app="oppia" itemscope itemtype="http://schema.org/Organization">
<head>
@require('../../base_components/header.html', {"title": "Oppia"})
<script>
Expand Down