Remove base controller from HTML tag to after Angular bootstrap and convert I18NFooter and Thanks to component directives. #7283
Conversation
This reverts commit c4cdb7f.
YashJipkate
requested review from
aks681,
DubeySandeep,
jameesjohn,
kevinlee12,
nithusha21,
seanlip,
sophiewu6,
vinitamurthi and
vojtechjelinek
as code owners
|
I tried closing and re-opening this PR to make it report the correct CircleCI setup status, but it looks like it doesn't. It does pass though: https://circleci.com/gh/YashJipkate/oppia/1118 |
There was a problem hiding this comment.
This looks good, thanks @YashJipkate. I'm fine with you making the changes I suggested in the next PR you do, so that we don't have to go through the Travis tests again. But if you decide to do that, please file an issue and assign it to yourself to keep track (and make sure the fixes happen in the very next PR).
One other question: this PR is fairly invasive. Have you tested each page carefully and does it work correctly? (and have you also verified manually that the meta tags get set correctly with the correct values?) Once you confirm this, we can merge.
Thanks!
| } | ||
| }); | ||
| }; | ||
| }]}; |
There was a problem hiding this comment.
The ']' should move to the next line to match the opening indentation.
The '}' should move to the line after that.
In general, when you see a gap that's too big between indentation levels, please fix it.
| $window.document.documentElement.setAttribute(attribute, value); | ||
| } | ||
| }; | ||
| }]); |
| }); | ||
| } | ||
| }; | ||
| }]); |
Explanation
This PR:
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.