Remove newlines, TODO for imports, modify MockOutcome

oppia · seanlip · Jul 19, 2019 · Jul 8, 2019 · Jul 8, 2019 · Jul 8, 2019
commit e26e464a175762c3548db42bfe6606fa90e9e157
@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for generic services.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the question player state service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -17,6 +17,8 @@
  *   editor page.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationDraftObjectFactory } from
   'domain/exploration/ExplorationDraftObjectFactory.ts';
 

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the controller of 'State Interactions'.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationFeaturesService } from
   'services/ExplorationFeaturesService.ts';
 

@@ -54,8 +54,8 @@ class MockOutcome {
 
 class MockOutcomeObjectFactory {
   createNew(
-      dest = null, feedbackTextId = null, feedbackText = null,
-      paramChanges = null) {
+      dest: string, feedbackTextId: string, feedbackText: string,
+      paramChanges: any) {
     return new MockOutcome(
       dest,
       new MockSubtitledHtml(feedbackText, feedbackTextId),
@@ -79,11 +79,11 @@ describe('Answer classification result object factory', () => {
 
   it('should create a new result', () => {
     var answerClassificationResult = acrof.createNew(
-      oof.createNew('default', '', []), 1, 0, DEFAULT_OUTCOME_CLASSIFICATION
+      oof.createNew('default', '', '', []), 1, 0, DEFAULT_OUTCOME_CLASSIFICATION
     );
 
     expect(answerClassificationResult.outcome).toEqual(
-      oof.createNew('default', '', []));
+      oof.createNew('default', '', '', []));
     expect(answerClassificationResult.answerGroupIndex).toEqual(1);
     expect(answerClassificationResult.ruleIndex).toEqual(0);
     expect(answerClassificationResult.classificationCategorization).toEqual(

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the Exploration object factory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for Interaction object factory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 
 require('domain/exploration/AnswerGroupObjectFactory.ts');

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the States object factory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Tests for QuestionContentsObjectFactory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for question update service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Tests for StateCardObjectFactory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 
 require('domain/exploration/InteractionObjectFactory.ts');

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the FeedbackImprovementCardObjectFactory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ExplorationDraftObjectFactory } from

diff --git a/core/templates/dev/head/domain/statistics/PlaythroughImprovementCardObjectFactory.ts b/core/templates/dev/head/domain/statistics/PlaythroughImprovementCardObjectFactory.ts
@@ -16,7 +16,6 @@
  * @fileoverview Factory for creating Playthrough Cards in the Improvements Tab.
  */
 
-
 require('domain/statistics/ImprovementActionButtonObjectFactory.ts');
 require('domain/utilities/UrlInterpolationService.ts');
 require('services/PlaythroughIssuesService.ts');

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the SuggestionImprovementCardObjectFactory.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ExplorationDraftObjectFactory } from

diff --git a/core/templates/dev/head/domain/topic/TopicUpdateServiceSpec.ts b/core/templates/dev/head/domain/topic/TopicUpdateServiceSpec.ts
@@ -16,7 +16,6 @@
  * @fileoverview Tests for Topic update service.
  */
 
-
 require('App.ts');
 require('domain/editor/undo_redo/UndoRedoService.ts');
 require('domain/exploration/RecordedVoiceoversObjectFactory.ts');

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the controller of the 'State Editor'.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the training data service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the exploration history tab.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationDraftObjectFactory } from
   'domain/exploration/ExplorationDraftObjectFactory.ts';
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the Compare versions Service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

diff --git a/...ates/dev/head/pages/exploration-editor-page/services/exploration-language-code.service.ts b/...ates/dev/head/pages/exploration-editor-page/services/exploration-language-code.service.ts
@@ -16,7 +16,6 @@
  * @fileoverview A data service that stores the exploration language code.
  */
 
-
 require(
   'pages/exploration-editor-page/services/exploration-property.service.ts');
 

@@ -17,6 +17,8 @@
  * of the exploration editor page.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationDraftObjectFactory } from
   'domain/exploration/ExplorationDraftObjectFactory.ts';
 

@@ -16,6 +16,8 @@
  * @fileoverview Tests for ExplorationStatesService.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -19,6 +19,8 @@
  * jasmine.any(Object).
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationFeaturesService } from
   'services/ExplorationFeaturesService.ts';
 import { AnswerClassificationResultObjectFactory } from

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for statistics services.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit test for the Translation status service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

diff --git a/...s/dev/head/pages/exploration-player-page/layout-directives/learner-local-nav.directive.ts b/...s/dev/head/pages/exploration-player-page/layout-directives/learner-local-nav.directive.ts
@@ -16,7 +16,6 @@
  * @fileoverview Directive for the local navigation in the learner view.
  */
 
-
 require('domain/utilities/UrlInterpolationService.ts');
 require('pages/exploration-player-page/services/exploration-engine.service.ts');
 require(

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the answer classification service
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the audio preloader service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

diff --git a/...dev/head/pages/exploration-player-page/services/audio-translation-manager.service.spec.ts b/...dev/head/pages/exploration-player-page/services/audio-translation-manager.service.spec.ts
@@ -16,7 +16,6 @@
  * @fileoverview Unit tests for the audio translation manager service.
  */
 
-
 require('domain/exploration/VoiceoverObjectFactory.ts');
 require(
   'pages/exploration-player-page/services/' +

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the extracting image files in state service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the image preloader service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { RuleObjectFactory } from 'domain/exploration/RuleObjectFactory.ts';
 import { WrittenTranslationObjectFactory } from
   'domain/exploration/WrittenTranslationObjectFactory.ts';

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the learner parameters service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the State classifier mapping service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ClassifierObjectFactory } from
   'domain/classifier/ClassifierObjectFactory.ts';
 

diff --git a/...skill-editor-page/editor-tab/skill-concept-card-editor/worked-example-editor.directive.ts b/...skill-editor-page/editor-tab/skill-concept-card-editor/worked-example-editor.directive.ts
@@ -16,7 +16,6 @@
  * @fileoverview Directive for the worked example editor.
  */
 
-
 require('domain/skill/SkillUpdateService.ts');
 require('domain/utilities/UrlInterpolationService.ts');
 require('pages/skill-editor-page/services/skill-editor-state.service.ts');

diff --git a/core/templates/dev/head/pages/skill-editor-page/services/skill-editor-state.service.spec.ts b/core/templates/dev/head/pages/skill-editor-page/services/skill-editor-state.service.spec.ts
@@ -16,7 +16,6 @@
  * @fileoverview Unit tests for SkillEditorStateService.js
  */
 
-
 require('domain/skill/SkillObjectFactory.ts');
 require('domain/skill/SkillRightsObjectFactory.ts');
 require('domain/skill/SkillUpdateService.ts');

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for TopicEditorStateService.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { TopicRightsObjectFactory } from
   'domain/topic/TopicRightsObjectFactory.ts';
 

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the ImprovementCardService.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ExplorationDraftObjectFactory } from

@@ -16,8 +16,11 @@
  * @fileoverview unit tests for the local save services.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationDraftObjectFactory } from
   'domain/exploration/ExplorationDraftObjectFactory.ts';
+
 require('services/LocalStorageService.ts');
 
 describe('LocalStorageService', function() {

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the playthrough service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { ExplorationFeaturesService } from
   'services/ExplorationFeaturesService.ts';
 

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for state rules stats service.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -17,6 +17,8 @@
  * statistics for a particular state.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { AnswerClassificationResultObjectFactory } from
   'domain/classifier/AnswerClassificationResultObjectFactory.ts';
 import { ClassifierObjectFactory } from

@@ -16,7 +16,6 @@
  * @fileoverview Unit tests python program tokenizer.
  */
 
-
 describe('Python program tokenizer', function() {
   beforeEach(angular.mock.module('oppia'));
 

@@ -16,6 +16,8 @@
  * @fileoverview Unit tests for the SVM prediction functions.
  */
 
+// TODO(YashJipkate) Remove the unnnecessary imports once the corresponding
+// non-spec file is upgraded.
 import { PredictionResultObjectFactory } from
   'domain/classifier/PredictionResultObjectFactory.ts';
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,6 @@ @@
      * @fileoverview A data service that stores the exploration language code.
      */
     require(
       'pages/exploration-editor-page/services/exploration-property.service.ts');
@@ Expand Down @@