Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade more services to Angular 8 #7145

Merged
merged 38 commits into from
Jul 19, 2019
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
13424bf
Untested work on PlaythroughIssueObjectFactory.ts
YashJipkate Jul 8, 2019
5c8bec3
Revert "Untested work on PlaythroughIssueObjectFactory.ts"
YashJipkate Jul 8, 2019
3b51282
Merge branch 'develop' into ser-up-more
YashJipkate Jul 8, 2019
3ae97e8
TopicRightsObjectFactory
YashJipkate Jul 8, 2019
7f22747
Lint fix
YashJipkate Jul 8, 2019
ffa8a7e
Removed unnecessary constructor statement
YashJipkate Jul 8, 2019
952d5c0
ClassifierObjectFactory
YashJipkate Jul 8, 2019
41987d5
AnswerClassificationResultObjectFactory
YashJipkate Jul 9, 2019
9990fe5
PredictionResultObjectFactory
YashJipkate Jul 9, 2019
027340d
WrittenTranslationObjectFactory
YashJipkate Jul 9, 2019
cc0ec34
RuleObjectFactory
YashJipkate Jul 9, 2019
906fd76
AudioTranslationObjectFactory
YashJipkate Jul 9, 2019
5b56005
ExplorationDraftObjectFactory
YashJipkate Jul 9, 2019
1502ad2
Fix failing FE in TopicRightsObjectFactory
YashJipkate Jul 10, 2019
f3a0997
Merge branch 'develop' into ser-up-more
YashJipkate Jul 10, 2019
5e96b0f
Add force bootstrap to all pages
YashJipkate Jul 10, 2019
6f906ef
function() -> () =>
YashJipkate Jul 10, 2019
feb8a4c
Merge
YashJipkate Jul 11, 2019
56f61f0
Merge proper
YashJipkate Jul 11, 2019
64f9fea
Merge branch 'develop' into ser-up-more
YashJipkate Jul 14, 2019
69681da
Update mocking method
YashJipkate Jul 14, 2019
04d7091
Merge branch 'develop' into ser-up-more
YashJipkate Jul 15, 2019
727a6bf
More typing
YashJipkate Jul 16, 2019
abb470f
Audit and newline
YashJipkate Jul 16, 2019
d8e573b
Merge branch 'develop' into ser-up-more
YashJipkate Jul 16, 2019
6fa6c50
Merge develop
YashJipkate Jul 16, 2019
0ca2eae
Merge branch 'develop' into ser-up-more
YashJipkate Jul 17, 2019
5c75b38
Stronger typing
YashJipkate Jul 17, 2019
0e557bf
Fix FE
YashJipkate Jul 17, 2019
dff56fd
Address comments
YashJipkate Jul 17, 2019
e26e464
Remove newlines, TODO for imports, modify MockOutcome
YashJipkate Jul 18, 2019
aa5133d
Fix matcher case, modify TODO for imports
YashJipkate Jul 18, 2019
951982b
Stronger typing in RuleObjectFactory
YashJipkate Jul 18, 2019
de7d2ad
Fix e2e
YashJipkate Jul 19, 2019
ce5cec8
Fix AJAX errors in Karma
YashJipkate Jul 19, 2019
b5c2ef9
Merge develop
YashJipkate Jul 19, 2019
b6f243f
Fix FE
YashJipkate Jul 19, 2019
3df1a3d
Add comment in csrftoken
YashJipkate Jul 19, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stronger typing in RuleObjectFactory
  • Loading branch information
YashJipkate committed Jul 18, 2019
commit 951982b9c181e1ec7f16494294b6bc70ec82abc6
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ import { downgradeInjectable } from '@angular/upgrade/static';
import { Injectable } from '@angular/core';

export class Rule {
type: any;
type: string;
inputs: any;
constructor(type: any, inputs: any) {
constructor(type: string, inputs: any) {
this.type = type;
this.inputs = inputs;
}
Expand All @@ -39,7 +39,7 @@ export class Rule {
providedIn: 'root'
})
export class RuleObjectFactory {
createNew(type: any, inputs: any) {
createNew(type: string, inputs: any) {
return new Rule(type, inputs);
}
createFromBackendDict(ruleDict: any) {
Expand Down