Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #6387: Remove tag_regex, invalid_parameter_names, show_trainable_unresolved_answers #7140

Merged
merged 7 commits into from
Jul 16, 2019
Merged

Fixes part of #6387: Remove tag_regex, invalid_parameter_names, show_trainable_unresolved_answers #7140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a68ecd
remove TAG REGEX from globals
jameesjohn Jul 13, 2019
dfe9378
remove INVALID_PARAMETER_NAMES from GLOBALS
jameesjohn Jul 14, 2019
5c424e2
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 14, 2019
25cd0b5
remove INVALID_PARAMETER_NAMES from GLOBALS
jameesjohn Jul 14, 2019
9df0c0a
move SHOW_TRAINABLE_UNRESOLVED_ANSWERS to constants
jameesjohn Jul 14, 2019
f68c018
changed to double quotes
jameesjohn Jul 15, 2019
3fc971d
revert pre_commit-hook
jameesjohn Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed to double quotes
  • Loading branch information
@jameesjohn
jameesjohn committed Jul 15, 2019
commit f68c018248ace826b8cbe83692cb3543146393ed
4 changes: 2 additions & 2 deletions assets/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,8 @@ var constants = {

// Invalid names for parameters used in expressions.
"INVALID_PARAMETER_NAMES": [
'answer', 'choices', 'abs', 'all', 'and', 'any', 'else',
'floor', 'if', 'log', 'or', 'pow', 'round', 'then'
"answer", "choices", "abs", "all", "and", "any", "else",
"floor", "if", "log", "or", "pow", "round", "then"
],

// Unfinished features.
Expand Down
Empty file modified scripts/pre_commit_hook.py
100644 → 100755
View file
Open in desktop
Empty file.