Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5002 remove GCS_RESOURCE_BUCKET_NAME from GLOBALS #7130

Merged
merged 23 commits into from
Jul 25, 2019
Merged

Fix part of #5002 remove GCS_RESOURCE_BUCKET_NAME from GLOBALS #7130

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7e7435b
remove GCS_RESOURCE_BUCKET_NAME from GLOBALS
jameesjohn Jul 12, 2019
3c169e3
refactorings
jameesjohn Jul 12, 2019
a9b1b20
refactor test
jameesjohn Jul 12, 2019
5469744
work on failing FE test
jameesjohn Jul 12, 2019
f9d53ea
still on failing test
jameesjohn Jul 12, 2019
435c25a
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 14, 2019
5f95d2e
address review comments
jameesjohn Jul 15, 2019
f4d9ae3
address review comment
jameesjohn Jul 16, 2019
d79e4ba
remove unneeded initialize
jameesjohn Jul 17, 2019
197c774
address review comments
jameesjohn Jul 17, 2019
5345bdb
work on erroring backend test
jameesjohn Jul 17, 2019
3012216
work on failing tests
jameesjohn Jul 18, 2019
2efc78f
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 22, 2019
2ca6ff5
address review comments and made the service initialize itself
jameesjohn Jul 22, 2019
c28854c
address review comments
jameesjohn Jul 22, 2019
4d837e1
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 22, 2019
bcf0bec
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 22, 2019
f02a37c
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 22, 2019
5028a22
working on FE test
jameesjohn Jul 22, 2019
25470cf
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 23, 2019
c832832
address review comments
jameesjohn Jul 24, 2019
f82ad3b
Merge branch 'develop' of https://github.com/oppia/oppia into globals…
jameesjohn Jul 24, 2019
f6ee206
address review comments and work on failing backend test
jameesjohn Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
working on FE test
  • Loading branch information
@jameesjohn
jameesjohn committed Jul 22, 2019
commit 5028a22b0fe14e57fe2112c10a16975d80bd67cb
2 changes: 1 addition & 1 deletion core/templates/dev/head/services/AssetsBackendApiService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ oppia.factory('AssetsBackendApiService', [
);
}
return _initialize().then(function() {
$q.resolve(UrlInterpolationService.interpolateUrl(
return $q.resolve(UrlInterpolationService.interpolateUrl(
(assetType === ASSET_TYPE_AUDIO ? AUDIO_DOWNLOAD_URL_TEMPLATE :
IMAGE_DOWNLOAD_URL_TEMPLATE), {
exploration_id: explorationId,
Expand Down