Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7010: Adds a linting check that ensures all TODO comments have a username with them #7114

Merged
merged 30 commits into from
Jul 23, 2019
Merged

Fixes #7010: Adds a linting check that ensures all TODO comments have a username with them #7114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4e0a755
Add linting function to check that TODO comments have a user
Jul 8, 2019
caa0297
Fix regex to match digits present in usernames
Jul 8, 2019
43cd237
Put the bad regex for todo comments in the global variables for TS, J…
Jul 9, 2019
a64dc31
Add regex to HTML bad patterns, and fix TODO comments with the codeow…
Jul 9, 2019
560f63e
Remove unnecessary comment
Jul 9, 2019
6ee8e38
Shorten line lengths in comments
Jul 9, 2019
ca14b12
Fix conflict in the pre_commit_linter
Jul 9, 2019
cff13bd
Add a user to a TODO comment in the jobs.py file
Jul 9, 2019
b83bf46
Merge branch 'develop' of https://github.com/oppia/oppia into todo-co…
Jul 9, 2019
f07882d
Fix TODO comment in extensions
Jul 9, 2019
6085cbf
Enforce the @ sign in TODO comments over the whole project
Jul 10, 2019
9b07764
Fix merge conflict
Jul 10, 2019
656cc9b
Delete files that had been deleted in develop
Jul 10, 2019
ad0bf5c
Change lowercase todo to uppercase TODO in pre_commit_linter
Jul 10, 2019
95370c5
Update branch with develop
Jul 14, 2019
148c817
Update with develop
Jul 16, 2019
199af2c
Update package lock with develop
Jul 17, 2019
ed60187
Merge branch 'develop' of https://github.com/oppia/oppia into todo-co…
Jul 17, 2019
b2e2916
Checkout the package-lock file to develop branch
Jul 17, 2019
5ce4456
Fix package-lock.json file
Jul 17, 2019
72a74c5
Force package-lock.json to be develop version
Jul 17, 2019
4d4bcbc
Update TODO comment format in a few new locations
Jul 17, 2019
5cfe078
Merge with develop
Jul 18, 2019
e29098a
Revert regexp to omitting @ sign
Jul 18, 2019
d1656dd
Fix TODO assignments
Jul 18, 2019
810f412
Add a message for sean's todo
Jul 18, 2019
bfa8731
Put the TODO regexp in its own structure, and enforce : and message
Jul 19, 2019
e950870
Fix merge conflict with develop
Jul 19, 2019
5417d21
Fix more TODO comment formats
Jul 19, 2019
b459568
Remove unnecessary + sign from message
Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update TODO comment format in a few new locations
  • Loading branch information
tmarchildon committed Jul 17, 2019
commit 4d4bcbc636bd6892c08194fe2a71a6b1a842b472
2 changes: 1 addition & 1 deletion core/domain/exp_fetchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def get_exploration_summary_by_id(exploration_id):
ExplorationSummary. The summary domain object corresponding to the
given exploration.
"""
# TODO(msl): Maybe use memcache similarly to get_exploration_by_id.
# TODO(@msl): Maybe use memcache similarly to get_exploration_by_id.
exp_summary_model = exp_models.ExpSummaryModel.get(
exploration_id)
if exp_summary_model:
Expand Down
4 changes: 2 additions & 2 deletions ...head/pages/exploration-editor-page/improvements-tab/services/improvement-modal.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ oppia.factory('ImprovementModalService', [
return $scope.activeThread.subject;
};

// TODO(Allan): Implement ability to edit suggestions before
// TODO(@Allan): Implement ability to edit suggestions before
// applying.
$scope.addNewMessage = function(threadId, tmpText, tmpStatus) {
if (threadId === null) {
Expand Down Expand Up @@ -145,7 +145,7 @@ oppia.factory('ImprovementModalService', [
$scope.activeThread.suggestion.stateName + '"');
};

// TODO(Allan): Implement ability to edit suggestions before
// TODO(@Allan): Implement ability to edit suggestions before
// applying.
$scope.addNewMessage = function(threadId, tmpText, tmpStatus) {
if (threadId === null) {
Expand Down