Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upgrades Requests (#6965)" #7088

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Revert "Upgrades Requests (#6965)" #7088

merged 1 commit into from
Jul 4, 2019

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Jul 4, 2019

This reverts commit f13a410.

PR #6965 introduced a serious regression that is causing the Oppia release process to break. The issue is when using Mailgun: requests-2.22.0 uses a direct import of urllib3 which cannot be found on the production server. (Earlier versions of the requests library actually included a bundled version of urllib3.)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.

@seanlip seanlip requested review from nithusha21, apb7 and NishealJ July 4, 2019 03:30
@seanlip seanlip requested a review from vojtechjelinek as a code owner July 4, 2019 03:30
@seanlip
Copy link
Member Author

seanlip commented Jul 4, 2019

@nithusha21 @apb7 Please note, this needs to be merged urgently. It is blocking the release.

apb7
apb7 approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seanlip!

@apb7 apb7 removed their assignment Jul 4, 2019
nithusha21
nithusha21 approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Also, thanks for looking into this :)

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #7088 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7088   +/-   ##
========================================
  Coverage    97.61%   97.61%           
========================================
  Files          379      379           
  Lines        63408    63408           
========================================
  Hits         61893    61893           
  Misses        1515     1515
Impacted Files Coverage Δ
appengine_config.py 50% <ø> (ø) ⬆️
core/tests/gae_suite.py 90.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b82c7...c8dcae4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #7088 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7088   +/-   ##
========================================
  Coverage    97.61%   97.61%           
========================================
  Files          379      379           
  Lines        63408    63408           
========================================
  Hits         61893    61893           
  Misses        1515     1515
Impacted Files Coverage Δ
appengine_config.py 50% <ø> (ø) ⬆️
core/tests/gae_suite.py 90.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b82c7...c8dcae4. Read the comment docs.

@seanlip seanlip merged commit e1d2202 into develop Jul 4, 2019
@seanlip seanlip deleted the downgrade-requests branch July 4, 2019 06:15
seanlip added a commit that referenced this pull request Jul 4, 2019
@seanlip
Revert "Upgrades Requests (#6965)" (#7088)
1a561e9 
This reverts commit f13a410.
@nithusha21 nithusha21 mentioned this pull request Jul 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apb7 apb7 apb7 approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@NishealJ NishealJ Awaiting requested review from NishealJ

@vojtechjelinek vojtechjelinek Awaiting requested review from vojtechjelinek

Assignees

@vojtechjelinek vojtechjelinek

@nithusha21 nithusha21

@NishealJ NishealJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanlip @nithusha21 @apb7 @vojtechjelinek @NishealJ