Services

oppia · seanlip · Jun 25, 2019 · Jun 18, 2019 · Jun 18, 2019 · Jun 18, 2019
commit 389110972ee117b585a83364d7049a0052377309
diff --git a/core/templates/dev/head/services/ContextService.ts b/core/templates/dev/head/services/ContextService.ts
@@ -17,18 +17,7 @@
  * context.
  */
 
-oppia.constant('PAGE_CONTEXT', {
-  EXPLORATION_EDITOR: 'editor',
-  EXPLORATION_PLAYER: 'learner',
-  QUESTION_EDITOR: 'question_editor',
-  QUESTION_PLAYER: 'question_player',
-  OTHER: 'other'
-});
-
-oppia.constant('EXPLORATION_EDITOR_TAB_CONTEXT', {
-  EDITOR: 'editor',
-  PREVIEW: 'preview'
-});
+require('services/services.constants.ts');
 
 oppia.factory('ContextService', [
   'UrlService', 'EXPLORATION_EDITOR_TAB_CONTEXT', 'PAGE_CONTEXT',

diff --git a/core/templates/dev/head/services/ExplorationFeaturesBackendApiService.ts b/core/templates/dev/head/services/ExplorationFeaturesBackendApiService.ts
@@ -17,8 +17,7 @@
  * configured to support.
  */
 
-oppia.constant(
-  'EXPLORATION_FEATURES_URL', '/explorehandler/features/<exploration_id>');
+require('services/services.constants.ts');
 
 oppia.factory('ExplorationFeaturesBackendApiService', [
   '$http', 'UrlInterpolationService', 'EXPLORATION_FEATURES_URL',

diff --git a/core/templates/dev/head/services/PlaythroughIssuesBackendApiService.ts b/core/templates/dev/head/services/PlaythroughIssuesBackendApiService.ts
@@ -19,15 +19,7 @@ require('domain/statistics/PlaythroughObjectFactory.ts');
 require('domain/statistics/PlaythroughIssueObjectFactory.ts');
 require('domain/utilities/UrlInterpolationService.ts');
 
-oppia.constant(
-  'FETCH_ISSUES_URL', '/issuesdatahandler/<exploration_id>');
-
-oppia.constant(
-  'FETCH_PLAYTHROUGH_URL',
-  '/playthroughdatahandler/<exploration_id>/<playthrough_id>');
-
-oppia.constant(
-  'RESOLVE_ISSUE_URL', '/resolveissuehandler/<exploration_id>');
+require('services/services.constants.ts');
 
 oppia.factory('PlaythroughIssuesBackendApiService', [
   '$http', 'PlaythroughIssueObjectFactory', 'PlaythroughObjectFactory',

diff --git a/core/templates/dev/head/services/PlaythroughService.ts b/core/templates/dev/head/services/PlaythroughService.ts
@@ -22,16 +22,7 @@ require('domain/utilities/StopwatchObjectFactory.ts');
 require('domain/utilities/UrlInterpolationService.ts');
 require('services/ExplorationFeaturesService.ts');
 
-oppia.constant(
-  'STORE_PLAYTHROUGH_URL',
-  '/explorehandler/store_playthrough/<exploration_id>');
-
-// Enables recording playthroughs from learner sessions.
-oppia.constant('EARLY_QUIT_THRESHOLD_IN_SECS', 45);
-oppia.constant('NUM_INCORRECT_ANSWERS_THRESHOLD', 3);
-oppia.constant('NUM_REPEATED_CYCLES_THRESHOLD', 3);
-oppia.constant('CURRENT_ACTION_SCHEMA_VERSION', 1);
-oppia.constant('CURRENT_ISSUE_SCHEMA_VERSION', 1);
+require('services/services.constants.ts');
 
 oppia.factory('PlaythroughService', [
   '$http', 'ExplorationFeaturesService', 'LearnerActionObjectFactory',

diff --git a/core/templates/dev/head/services/PromoBarService.ts b/core/templates/dev/head/services/PromoBarService.ts
@@ -16,11 +16,7 @@
  * @fileoverview Service Promo bar.
  */
 
-// Whether to enable the promo bar functionality. This does not actually turn on
-// the promo bar, as that is gated by a config value (see config_domain). This
-// merely avoids checking for whether the promo bar is enabled for every Oppia
-// page visited.
-oppia.constant('ENABLE_PROMO_BAR', true);
+require('services/services.constants.ts');
 
 oppia.factory('PromoBarService', [
   '$http', '$q', 'ENABLE_PROMO_BAR',

diff --git a/core/templates/dev/head/services/RteHelperService.ts b/core/templates/dev/head/services/RteHelperService.ts
@@ -16,7 +16,7 @@
  * @fileoverview A helper service for the Rich text editor(RTE).
  */
 
-oppia.constant('RTE_COMPONENT_SPECS', richTextComponents);
+require('services/services.constants.ts');
 
 oppia.factory('RteHelperService', [
   '$document', '$filter', '$interpolate', '$log', '$uibModal',

diff --git a/core/templates/dev/head/services/SearchService.ts b/core/templates/dev/head/services/SearchService.ts
@@ -16,7 +16,7 @@
  * @fileoverview search service for activityTilesInfinityGrid
  */
 
-oppia.constant('SEARCH_DATA_URL', '/searchhandler/data');
+require('services/services.constants.ts');
 
 oppia.factory('SearchService', [
   '$http', '$log', '$rootScope', '$translate', 'SEARCH_DATA_URL',

diff --git a/core/templates/dev/head/services/StateTopAnswersStatsBackendApiService.ts b/core/templates/dev/head/services/StateTopAnswersStatsBackendApiService.ts
@@ -16,9 +16,7 @@
  * @fileoverview Service to fetch statistics about an exploration's states.
  */
 
-oppia.constant(
-  'STATE_ANSWER_STATS_URL',
-  '/createhandler/state_answer_stats/<exploration_id>');
+require('services/services.constants.ts');
 
 oppia.factory('StateTopAnswersStatsBackendApiService', [
   '$http', 'UrlInterpolationService', 'STATE_ANSWER_STATS_URL',

diff --git a/core/templates/dev/head/services/services.constants.ts b/core/templates/dev/head/services/services.constants.ts
@@ -0,0 +1,68 @@
+// Copyright 2018 The Oppia Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS-IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+/**
+ * @fileoverview Constants for shared services across Oppia.
+ */
+
+oppia.constant('PAGE_CONTEXT', {
+  EXPLORATION_EDITOR: 'editor',
+  EXPLORATION_PLAYER: 'learner',
+  QUESTION_EDITOR: 'question_editor',
+  QUESTION_PLAYER: 'question_player',
+  OTHER: 'other'
+});
+
+oppia.constant('EXPLORATION_EDITOR_TAB_CONTEXT', {
+  EDITOR: 'editor',
+  PREVIEW: 'preview'
+});
+
+oppia.constant(
+  'EXPLORATION_FEATURES_URL', '/explorehandler/features/<exploration_id>');
+
+oppia.constant(
+  'FETCH_ISSUES_URL', '/issuesdatahandler/<exploration_id>');
+
+oppia.constant(
+  'FETCH_PLAYTHROUGH_URL',
+  '/playthroughdatahandler/<exploration_id>/<playthrough_id>');
+
+oppia.constant(
+  'RESOLVE_ISSUE_URL', '/resolveissuehandler/<exploration_id>');
+
+oppia.constant(
+  'STORE_PLAYTHROUGH_URL',
+  '/explorehandler/store_playthrough/<exploration_id>');
+
+// Enables recording playthroughs from learner sessions.
+oppia.constant('EARLY_QUIT_THRESHOLD_IN_SECS', 45);
+oppia.constant('NUM_INCORRECT_ANSWERS_THRESHOLD', 3);
+oppia.constant('NUM_REPEATED_CYCLES_THRESHOLD', 3);
+oppia.constant('CURRENT_ACTION_SCHEMA_VERSION', 1);
+oppia.constant('CURRENT_ISSUE_SCHEMA_VERSION', 1);
+
+// Whether to enable the promo bar functionality. This does not actually turn on
+// the promo bar, as that is gated by a config value (see config_domain). This
+// merely avoids checking for whether the promo bar is enabled for every Oppia
+// page visited.
+oppia.constant('ENABLE_PROMO_BAR', true);
+
+oppia.constant('RTE_COMPONENT_SPECS', richTextComponents);
+
+oppia.constant('SEARCH_DATA_URL', '/searchhandler/data');
+
+oppia.constant(
+  'STATE_ANSWER_STATS_URL',
+  '/createhandler/state_answer_stats/<exploration_id>');