Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #5002: Remove CSRF token from GLOBALS #6951

Merged
merged 45 commits into from
Jul 2, 2019
Merged

Fixes part of #5002: Remove CSRF token from GLOBALS #6951

Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
f117d8a
remove csrf global
jameesjohn Jun 16, 2019
6bbc862
refactor tests
jameesjohn Jun 17, 2019
809e4b3
lint issues
jameesjohn Jun 17, 2019
3a917c3
lint issues
jameesjohn Jun 17, 2019
b7ff267
work on fe tests
jameesjohn Jun 17, 2019
efe0d3c
working on failing tests
jameesjohn Jun 17, 2019
5bd0884
work on e2e tests
jameesjohn Jun 18, 2019
9e5a5e4
minor issue in admin
jameesjohn Jun 18, 2019
427ea8e
address some review comments
jameesjohn Jun 18, 2019
bf83726
work on failing tests
jameesjohn Jun 18, 2019
dfac34f
erroring tests
jameesjohn Jun 18, 2019
f964002
still on tests
jameesjohn Jun 18, 2019
bca6d72
address more review comments
jameesjohn Jun 18, 2019
828e486
still on the test issue
jameesjohn Jun 19, 2019
f9daa2c
fix error
jameesjohn Jun 19, 2019
b975bfd
still on tests
jameesjohn Jun 19, 2019
a198edf
Merge branch 'develop' of https://github.com/oppia/oppia into csrf-gl…
jameesjohn Jun 21, 2019
6510b39
work on erroring tests
jameesjohn Jun 21, 2019
261a101
still on failing tests
jameesjohn Jun 21, 2019
def2e12
address review comments
jameesjohn Jun 22, 2019
496c7a4
Merge branch 'develop' of https://github.com/oppia/oppia into csrf-gl…
jameesjohn Jun 22, 2019
ab95746
address review comment
jameesjohn Jun 22, 2019
e42f68c
address review comment and working on tests
jameesjohn Jun 23, 2019
f7c50c8
address review comment
jameesjohn Jun 23, 2019
c102738
work on failing tests
jameesjohn Jun 25, 2019
0eac0d7
Merge branch 'develop' of https://github.com/oppia/oppia into csrf-gl…
jameesjohn Jun 25, 2019
30a6694
remove csrf from other pages
jameesjohn Jun 25, 2019
1885acc
fix lint issue
jameesjohn Jun 25, 2019
99c76ff
work on failing tests
jameesjohn Jun 25, 2019
cbe194b
use promises in csrf token
jameesjohn Jun 26, 2019
8a05062
refactor to use jQuery
jameesjohn Jun 26, 2019
65017af
Address review comments.
jameesjohn Jun 26, 2019
5eee0c3
remove unnecessary imports from base.ts
jameesjohn Jun 26, 2019
ce810e2
work on failing FE test
jameesjohn Jun 27, 2019
299b45e
fix failing tests
jameesjohn Jun 27, 2019
997257b
address review comments
jameesjohn Jun 28, 2019
4127098
work on FE tests
jameesjohn Jun 28, 2019
19cd171
work on failing test
jameesjohn Jun 28, 2019
aa3010b
refactor based on test
jameesjohn Jun 28, 2019
f1ec691
address review comments
jameesjohn Jun 28, 2019
b143909
Merge branch 'develop' of https://github.com/oppia/oppia into csrf-gl…
jameesjohn Jun 29, 2019
ffc26b1
address review comments and fix failing Travis test
jameesjohn Jun 29, 2019
493a049
work on failing tests
jameesjohn Jun 29, 2019
cee7068
Merge branch 'develop' of https://github.com/oppia/oppia into csrf-gl…
jameesjohn Jul 1, 2019
79bc7a0
work on fe tests
jameesjohn Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work on failing tests
  • Loading branch information
@jameesjohn
jameesjohn committed Jun 29, 2019
commit 493a049a4ef2d0a0feb6586e965220b8b5a42489
3 changes: 1 addition & 2 deletions core/controllers/question_editor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ def test_post_with_invalid_question_returns_400_status(self):

def test_post_with_too_many_skills_returns_400(self):
self.login(self.ADMIN_EMAIL)
response = self.get_html_response(feconf.CREATOR_DASHBOARD_URL)
csrf_token = self.get_csrf_token_from_response(response)
csrf_token = self.get_new_csrf_token()
skill_ids = [1, 2, 3, 4]
self.post_json(
'%s/%s' % (feconf.NEW_QUESTION_URL, skill_ids),
Expand Down