Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5627 : Stop recording should stop microphone and angular-recorder should be replaced. #6708

Merged
merged 34 commits into from
Jun 1, 2019
Merged

Fix #5627 : Stop recording should stop microphone and angular-recorder should be replaced. #6708

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
6bc598c
added base functional recording service to replace angular-recorder. …
mzaman07 May 7, 2019
e7210a0
Something wrong with rootScope loadingMessage when you change state t…
mzaman07 May 7, 2019
c85f282
lint fixed
mzaman07 May 7, 2019
3cf277c
webworker compilation in ts set
mzaman07 May 7, 2019
69881bc
reverted tsconfig.json and added karma framework thread loading check…
mzaman07 May 7, 2019
d7f0848
lint fixes
mzaman07 May 7, 2019
c086c4f
updated branch and fixed merge conflicts.
mzaman07 May 17, 2019
874ca92
Changed mp3Conveter to a ts-compiler friendly version.
mzaman07 May 17, 2019
d4f638c
lint fixes
mzaman07 May 17, 2019
5dd9f42
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 May 18, 2019
722938e
used in library realtime worker and changed time duration so that the…
mzaman07 May 19, 2019
30955ba
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 May 19, 2019
394585e
lint and extra fixes
mzaman07 May 19, 2019
0dd2a5f
Added web audio api typedefs and using webworker typedefs for FileRea…
mzaman07 May 21, 2019
434e5b8
readded audio recording preview for unsaved recording.
mzaman07 May 21, 2019
19ee5e7
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 May 21, 2019
d643d3d
Added wave-surfer back into recording. Changed from FileReader Api ba…
mzaman07 May 21, 2019
8f8527d
lint fixes
mzaman07 May 21, 2019
dc20ba3
more lint fixes is final now.
mzaman07 May 21, 2019
b5b1bcc
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 May 21, 2019
879ab52
fixed typescript based issue
mzaman07 May 22, 2019
858ce62
removed references to angular-recorder/angular-audio-recorder
mzaman07 May 22, 2019
0541cf3
fixed duplication of canvas on multiple re-records
mzaman07 May 22, 2019
ce59d5c
fixed based on review
mzaman07 May 27, 2019
d67f435
fixed missed error.
mzaman07 May 27, 2019
22affb6
fixed audioContext referencing and VoiceoverRecorderService to be set…
mzaman07 May 27, 2019
acadf01
lint checks
mzaman07 May 27, 2019
37f06b9
lint fix
mzaman07 May 27, 2019
61c47f6
Sorted require() alphabetically in ascending order and removed @types…
mzaman07 May 27, 2019
cf8566f
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 May 30, 2019
1b269cd
changed AppInit.ts for improved readability.
mzaman07 May 30, 2019
2ff1664
Merge remote-tracking branch 'upstream/develop' into mp3-recorder
mzaman07 Jun 1, 2019
a5ebd6c
Changed comments to be a full sentence and switched variable to prope…
mzaman07 Jun 1, 2019
49bf1b7
Corrected comment because action is singular as opposed to plural.
mzaman07 Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed missed error.
  • Loading branch information
@mzaman07
mzaman07 committed May 27, 2019
commit d67f43502dc0a0296c86705601cfcd4ec65cd3c1
2 changes: 1 addition & 1 deletion ...mplates/dev/head/pages/exploration_editor/translation_tab/AudioTranslationBarDirective.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ oppia.directive('audioTranslationBar', [
if ($scope.voiceoverRecorder) {
if ($scope.voiceoverRecorder.status().isRecording &&
$scope.showRecorderWarning) {
$scope.voiceoverRecorder.stopRecording();
$scope.voiceoverRecorder.stopRecord();
cancelTimer();
$scope.voiceoverRecorder.closeRecorder();
}
Expand Down