Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6449: Added check for CODEOWNERS to ensure that the most important rules are at the end. #6560

Merged
merged 16 commits into from
Jun 13, 2019
Merged

Fix #6449: Added check for CODEOWNERS to ensure that the most important rules are at the end. #6560

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7423c00
Added imp rules check
YashJipkate Apr 6, 2019
bea64b0
Removed unnecessary comment
YashJipkate Apr 6, 2019
c2c94e8
Added comments, alphabetize list and improved error message
YashJipkate Apr 19, 2019
35abb55
Merge branch 'develop' into codeowner-imp-rules
YashJipkate May 1, 2019
9d2e3c3
Review addressed
YashJipkate May 1, 2019
2df107a
Improved error messages
YashJipkate May 3, 2019
78d4b16
Merge and break codeowners check function
YashJipkate May 19, 2019
644c6a2
Fix lint
YashJipkate May 20, 2019
026e091
Merge develop
YashJipkate May 29, 2019
65a4c8f
Address review
YashJipkate May 29, 2019
596f823
Address review
YashJipkate Jun 6, 2019
0b5b9b9
Merge branch 'develop' into codeowner-imp-rules
YashJipkate Jun 12, 2019
1c3f7c4
Changed working rule to use set operations
YashJipkate Jun 12, 2019
7e2ad7c
Fix lint
YashJipkate Jun 12, 2019
283997d
Address review
YashJipkate Jun 13, 2019
6679d6c
Fix lint
YashJipkate Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@YashJipkate
YashJipkate committed Jun 12, 2019
commit 7e2ad7c07adf683adf52869f224ca1cecbb7a2f6
2 changes: 1 addition & 1 deletion scripts/pre_commit_linter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,7 +2251,7 @@ def check_for_important_rules_at_bottom_of_codeowners(
'from the \'CODEOWNER_IMPORTANT_PATHS\' list in '
'scripts/pre_commit_linter.py if it is no longer an '
'important rule.' % (CODEOWNER_FILEPATH, rule))
failed = True
failed = True
return failed

def _check_codeowner_file(self):
Expand Down