Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5798: Introduce Improvements Tab to Exploration Editor #5991

Merged
merged 142 commits into from
Jan 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
142 commits
Select commit Hold shift + click to select a range
c9d4d22
Fix hola's multiple choice question.
brianrodri Aug 11, 2018
9b16504
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Aug 12, 2018
80cf6c9
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Aug 12, 2018
1904b2d
Merge branch 'develop' of https://github.com/brianrodri/oppia into de…
brianrodri Aug 15, 2018
1d21cf8
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 5, 2018
0d41226
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 6, 2018
cbd7666
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 8, 2018
8db0992
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 15, 2018
18658de
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 23, 2018
bca45b2
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Sep 23, 2018
d956212
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 15, 2018
67bf6e2
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 18, 2018
afc36e2
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 20, 2018
926a925
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 22, 2018
bfb2fb7
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 29, 2018
e4efd3e
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Oct 30, 2018
0478611
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Nov 5, 2018
0899b3a
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Nov 22, 2018
0e690ef
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Nov 27, 2018
050f37f
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 2, 2018
37aef06
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 6, 2018
c18d79c
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 6, 2018
1cd3750
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 6, 2018
005ce4d
Merge branch 'develop' of https://github.com/brianrodri/oppia into de…
brianrodri Dec 7, 2018
139112d
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 7, 2018
e57222b
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 14, 2018
edb3aeb
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 15, 2018
fcaa078
Merge remote-tracking branch 'upstream/develop' into develop
brianrodri Dec 16, 2018
d477a6d
add config_property for showing the issues tab
brianrodri Dec 16, 2018
558ac64
fix indentation
brianrodri Dec 16, 2018
1dc072b
shorter description
brianrodri Dec 16, 2018
454be74
fetch issue_tab_exposed from backend
brianrodri Dec 16, 2018
7037e47
make isIssuesTabExposed a function
brianrodri Dec 16, 2018
b981b9c
redirect away from issues if it is not exposed
brianrodri Dec 16, 2018
050b76c
remove unused import
brianrodri Dec 16, 2018
8476ea6
fix copyright date
brianrodri Dec 16, 2018
e08c031
better naming for config variable
brianrodri Dec 16, 2018
daee496
explicit function definition
brianrodri Dec 16, 2018
8863330
stop showing feedback count
brianrodri Dec 16, 2018
338f359
stop showing unrelated data
brianrodri Dec 16, 2018
0d7b739
make helper function
brianrodri Dec 16, 2018
9f5f9a8
better handler name
brianrodri Dec 17, 2018
e6806f0
better name
brianrodri Dec 17, 2018
04742ce
better name for service
brianrodri Dec 17, 2018
8376482
fix line-too-long error
brianrodri Dec 17, 2018
96b6078
sort imports
brianrodri Dec 17, 2018
7a37d6a
rename backend url
brianrodri Dec 17, 2018
d028d15
commit the new service
brianrodri Dec 17, 2018
54666db
connect issues_tab to its controller
brianrodri Dec 17, 2018
d9b4e1a
add message for issues tab
brianrodri Dec 17, 2018
ba2c5b0
reorganize redirect routes
brianrodri Dec 17, 2018
f97941c
fix fileoverview
brianrodri Dec 17, 2018
d9acb7a
use bug_report material icon
brianrodri Dec 17, 2018
06d0ff3
add dependency to routerservice
brianrodri Dec 17, 2018
f4f128a
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 17, 2018
3b41e1b
fix line-too-long error
brianrodri Dec 17, 2018
fac4325
save line-too-long error fix for different PR
brianrodri Dec 17, 2018
f3eaa94
accept an exploration id for the features backend api call
brianrodri Dec 17, 2018
8ae064c
s/EXPLORATION_FEATURES_URL/EXPLORATION_EDITOR_FEATURES_URL/
brianrodri Dec 17, 2018
8d9ed8c
use better acl
brianrodri Dec 17, 2018
f525f14
prettier issues tab template
brianrodri Dec 17, 2018
33afc0a
Simplify html structure
brianrodri Dec 17, 2018
a582101
Fix indentation
brianrodri Dec 17, 2018
9e05a71
add programmatic data
brianrodri Dec 17, 2018
0387d1b
use length of open issues
brianrodri Dec 17, 2018
fe58cf1
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 17, 2018
6b0cb78
remove i18n from TODO
brianrodri Dec 17, 2018
248364f
revert to dev mode
brianrodri Dec 17, 2018
b8faedf
remove unused scope variable
brianrodri Dec 17, 2018
8946e68
s/exposed/enabled
brianrodri Dec 18, 2018
d94a8d8
s/allData/combinedData
brianrodri Dec 18, 2018
3ee2d5a
delete extraneous space
brianrodri Dec 18, 2018
076efa2
give players access to exploration features
brianrodri Dec 18, 2018
cdc9780
s/Exploration\w*Features/ExplorationFeatures
brianrodri Dec 18, 2018
fa0023e
sort imports
brianrodri Dec 18, 2018
3d9b5d3
rename actual file
brianrodri Dec 18, 2018
fc105c7
add conditional to existing expression
brianrodri Dec 18, 2018
0844141
use different constant to keep strings together
brianrodri Dec 18, 2018
f99e3fa
explain constants
brianrodri Dec 18, 2018
489bb28
sort imports
brianrodri Dec 18, 2018
1143f9a
remove useless parenthesis
brianrodri Dec 18, 2018
e0f0bc3
fix headers
brianrodri Dec 18, 2018
ae61ac2
use propere name
brianrodri Dec 18, 2018
997e60f
sort imports
brianrodri Dec 18, 2018
75a780a
sort imports
brianrodri Dec 18, 2018
603731c
sort imports
brianrodri Dec 18, 2018
85b2d03
use new name
brianrodri Dec 18, 2018
319dd34
fix quote-props error
brianrodri Dec 18, 2018
7f6951a
stop using excessive format for comment headers.
brianrodri Dec 18, 2018
e46a2f3
s/TAGS/TABS
brianrodri Dec 18, 2018
9705ffb
add missing constant access
brianrodri Dec 18, 2018
417253e
s/EXPLORATION_EDITOR_FEATURES_URL/EXPLORATION_FEATURES_URL
brianrodri Dec 18, 2018
7b7b689
sort imports
brianrodri Dec 18, 2018
5cb11fd
simplify function assignment
brianrodri Dec 18, 2018
5743a3b
simplify function assignment
brianrodri Dec 18, 2018
cb8f631
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 18, 2018
7fd2499
remove unneeded prefix
brianrodri Dec 18, 2018
d016a09
condense object definition
brianrodri Dec 18, 2018
c0e97b0
s/_tabs/tabStatus
brianrodri Dec 18, 2018
671fb63
render nothing if issue type does not exist
brianrodri Dec 18, 2018
59133a5
s/exploration_editor/explorehandler for URL
brianrodri Dec 18, 2018
3dd7359
store active tab directly
brianrodri Dec 18, 2018
e6db424
use i18n strings
brianrodri Dec 18, 2018
9c12b6f
fix line-too-long
brianrodri Dec 18, 2018
4b6c724
Update core/templates/dev/head/pages/exploration_editor/settings_tab/…
nithusha21 Dec 18, 2018
20d29b7
add human readable issues name
brianrodri Dec 18, 2018
368318c
reorder words
brianrodri Dec 18, 2018
1643b8b
Merge branch 'introduce-issues-tab' of https://github.com/brianrodri/…
brianrodri Dec 18, 2018
afe4474
s/issues/improvements
brianrodri Dec 19, 2018
6ef22f9
fix wrong function call
brianrodri Dec 19, 2018
d9e3613
s/issues/improvements
brianrodri Dec 19, 2018
cf73427
fix i18n
brianrodri Dec 19, 2018
46d159f
finishing touches
brianrodri Dec 19, 2018
ed9dbf8
fix line-too-long
brianrodri Dec 19, 2018
81be897
fix line-too-long
brianrodri Dec 19, 2018
dc181d2
fix line-too-long
brianrodri Dec 19, 2018
75f5b49
fix remaining line-too-long errors
brianrodri Dec 19, 2018
393b948
fix line-too-long
brianrodri Dec 19, 2018
a7f36a4
fix spacing
brianrodri Dec 19, 2018
9d1ba63
sort i18n definitions
brianrodri Dec 19, 2018
4c7a73e
fix wrong import
brianrodri Dec 19, 2018
9d7496b
fix line-too-long
brianrodri Dec 19, 2018
da661f0
move improvements next to stats
brianrodri Dec 19, 2018
8e5db8e
only use 3 cards
brianrodri Dec 19, 2018
b4780da
only use 2 cards
brianrodri Dec 19, 2018
c02f86e
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 19, 2018
8eb92a0
remove extra newline
brianrodri Dec 19, 2018
80b044a
remove todos
brianrodri Dec 19, 2018
5140f54
Make ImprovementsTab a directive
brianrodri Dec 19, 2018
97192f5
suffix with directive
brianrodri Dec 19, 2018
8cef109
s/activeTab/activeTabName
brianrodri Dec 19, 2018
09582e6
improve JSDoc
brianrodri Dec 19, 2018
3ac235b
require logged in to show improvements tab
brianrodri Dec 19, 2018
f62274b
Update improvements_tab_directive.html
brianrodri Dec 19, 2018
438a04b
improve docstrings
brianrodri Dec 19, 2018
f34da53
remove directive suffix
brianrodri Dec 20, 2018
8cd645b
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 20, 2018
b359581
prefer ng-if
brianrodri Dec 20, 2018
8077f0b
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 21, 2018
35fa911
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 22, 2018
bb2d52a
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 26, 2018
c692a18
Merge remote-tracking branch 'upstream/develop' into introduce-issues…
brianrodri Dec 31, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@
"I18N_GET_STARTED_PAGE_PARAGRAPH_9": "When learners go through your exploration, they can send you feedback to alert you to problems or to share ideas for making it better.",
"I18N_GET_STARTED_PAGE_PARAGRAPH_9_HEADING": "Improve Your Exploration",
"I18N_GET_STARTED_PAGE_TITLE": "Get Started",
"I18N_IMPROVEMENTS_TAB_FEEDBACK_DESCRIPTION": "A learner had something to say about your exploration.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_CYCLIC_TRANSITIONS_DESCRIPTION": "A player has quit an exploration after repeatedly cycling through a sequence of cards.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_EARLY_QUIT_DESCRIPTION": "A player has quit an exploration soon after starting.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_MULTIPLE_INCORRECT_ANSWERS_DESCRIPTION": "A player has quit an exploration after entering many incorrect answers.",
"I18N_IMPROVEMENTS_TAB_SUMMARY_ARCHIVED_ISSUES": "Archived Issues",
"I18N_IMPROVEMENTS_TAB_SUMMARY_OPEN_ISSUES": "Open Issues",
"I18N_IMPROVEMENTS_TAB_SUMMARY_RESOLVED_ISSUES": "Resolved Issues",
"I18N_IMPROVEMENTS_TAB_UNRESOLVED_ANSWER_DESCRIPTION": "A commonly entered answer has no explicit feedback from you.",
"I18N_INTERACTIONS_FRACTIONS_INPUT_PLACEHOLDER": "Enter a fraction in the form x/x, or a mixed number in the form x x/x.",
"I18N_INTERACTIONS_FRACTIONS_INPUT_PLACEHOLDER_NO_INTEGER": "Enter a fraction in the form x/x.",
"I18N_INTERACTIONS_GRAPH_ADD_EDGE": "Add Edge",
Expand Down
8 changes: 8 additions & 0 deletions assets/i18n/qqq.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@
"I18N_GET_STARTED_PAGE_PARAGRAPH_9": "Text on the Get Started page that explains the process for creating an Oppia activity at a high level.\n{{Identical|Get started}}",
"I18N_GET_STARTED_PAGE_PARAGRAPH_9_HEADING": "Paragraph heading on the Get Started page that explains the process for creating an Oppia activity at a high level.\n{{Identical|Get started}}",
"I18N_GET_STARTED_PAGE_TITLE": "Title of the Get Started page that explains the process for creating an Oppia activity at a high level.\n{{Identical|Get started}}",
"I18N_IMPROVEMENTS_TAB_FEEDBACK_DESCRIPTION": "Text displayed to describe an issue card describing a feedback thread about the exploration.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_CYCLIC_TRANSITIONS_DESCRIPTION": "Text displayed to describe an issue card describing a playthrough demonstrating a learner that had quit after being stuck moving through the same set of cards repeatedly.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_EARLY_QUIT_DESCRIPTION": "Text displayed to describe an issue card describing a playthrough demonstrating a learner that quit immediately after starting an exploration.",
"I18N_IMPROVEMENTS_TAB_PLAYTHROUGH_ISSUES_MULTIPLE_INCORRECT_ANSWERS_DESCRIPTION": "Text displayed to describe an issue card describing playthrough demonstrating a learner that quit after entering incorrect answers repeatedly.",
"I18N_IMPROVEMENTS_TAB_SUMMARY_ARCHIVED_ISSUES": "Text displayed in the summary card to show the number of issues that have been archived.",
"I18N_IMPROVEMENTS_TAB_SUMMARY_OPEN_ISSUES": "Text displayed in the summary card to show the number of issues that are open and require attention.",
"I18N_IMPROVEMENTS_TAB_SUMMARY_RESOLVED_ISSUES": "Text displayed in the summary card to show the number of issues that have been given attention and deemed fixed by Oppia.",
"I18N_IMPROVEMENTS_TAB_UNRESOLVED_ANSWER_DESCRIPTION": "A commonly entered answer has no explicit feedback from you.",
"I18N_INTERACTIONS_FRACTIONS_INPUT_PLACEHOLDER": "Text displayed in the fractions interaction input as a placeholder.",
"I18N_INTERACTIONS_FRACTIONS_INPUT_PLACEHOLDER_NO_INTEGER": "Text displayed in the fractions interaction input as a placeholder when no integer part is allowed.",
"I18N_INTERACTIONS_GRAPH_ADD_EDGE": "Text displayed in a button in a graph interaction inside the graph editor - When the user clicks the button, he can add a new line (edge) to the graph.",
Expand Down
14 changes: 14 additions & 0 deletions core/controllers/editor.py
Original file line number Diff line number Diff line change
Expand Up @@ -878,3 +878,17 @@ def get(self, exploration_id):
self.render_json({
'unresolved_answers': unresolved_answers_with_frequency
})


class ExplorationFeaturesHandler(EditorHandler):
"""Returns features the given exploration is configured to support."""

GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON

@acl_decorators.can_play_exploration
def get(self, unused_exploration_id):
"""Handles GET requests for an exploration's features."""
self.render_json({
'is_improvements_tab_enabled':
config_domain.IS_IMPROVEMENTS_TAB_ENABLED.value,
})
5 changes: 5 additions & 0 deletions core/domain/config_domain.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,3 +274,8 @@ def get_config_property_schemas(cls):
RECORD_PLAYTHROUGH_PROBABILITY = ConfigProperty(
'record_playthrough_probability', FLOAT_SCHEMA,
'The probability of recording playthroughs', 0.2)

IS_IMPROVEMENTS_TAB_ENABLED = ConfigProperty(
'is_improvements_tab_enabled', BOOL_SCHEMA,
'Exposes the Improvements Tab for creators in the exploration editor.',
False)
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@ oppia.directive('collectionEditorNavbarBreadcrumb', [
preview: 'Preview',
settings: 'Settings',
stats: 'Statistics',
history: 'History'
improvements: 'Improvements',
history: 'History',
};

$scope.collection = CollectionEditorStateService.getCollection();

$scope.getCurrentTabName = function() {
return _TAB_NAMES_TO_HUMAN_READABLE_NAMES[
RouterService.getTabStatuses().active];
RouterService.getActiveTabName()];
};

$scope.editCollectionTitle = function() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ oppia.directive('collectionEditorNavbar', [
$scope.isSaveInProgress = (
CollectionEditorStateService.isSavingCollection);

$scope.getTabStatuses = RouterService.getTabStatuses;
$scope.getActiveTabName = RouterService.getActiveTabName;
$scope.selectMainTab = RouterService.navigateToMainTab;
$scope.selectPreviewTab = RouterService.navigateToPreviewTab;
$scope.selectSettingsTab = RouterService.navigateToSettingsTab;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@

{% block content %}
<div ng-controller="CollectionEditor">
<div ng-if="getTabStatuses().active === 'main'">
<div ng-if="getActiveTabName() === 'main'">
<collection-main-tab></collection-main-tab>
</div>

<div ng-show="getTabStatuses().active === 'settings'">
<div ng-show="getActiveTabName() === 'settings'">
<collection-settings-tab></collection-settings-tab>
</div>

<div ng-show="getTabStatuses().active === 'history'">
<div ng-show="getActiveTabName() === 'history'">
<collection-history-tab></collection-history-tab>
</div>

<div ng-show="getTabStatuses().active === 'stats'">
<div ng-show="getActiveTabName() === 'stats'">
<collection-statistics-tab></collection-statistics-tab>
</div>
</div>
Expand Down Expand Up @@ -134,6 +134,7 @@
<script src="/templates/dev/head/pages/exploration_editor/ExplorationDataService.js"></script>
<script src="/templates/dev/head/pages/exploration_editor/AngularNameService.js"></script>
<script src="/templates/dev/head/pages/exploration_editor/ExplorationEditor.js"></script>
<script src="/templates/dev/head/pages/exploration_editor/ExplorationFeaturesService.js"></script>
<script src="/templates/dev/head/pages/exploration_editor/RouterService.js"></script>
<script src="/templates/dev/head/pages/exploration_editor/ChangesInHumanReadableFormService.js"></script>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ul class="nav navbar-nav oppia-navbar-nav navbar-right ng-cloak" style="margin-left: 20px;">
<!-- Editor -->
<li ng-class="{'active': getTabStatuses().active === 'main', 'uib-dropdown': getWarningsCount()}" ng-attr-uib-dropdown="<[getWarningsCount()]>">
<li ng-class="{'active': getActiveTabName() === 'main', 'uib-dropdown': getWarningsCount()}" ng-attr-uib-dropdown="<[getWarningsCount()]>">
<a href="#" uib-tooltip="Editor" ng-click="selectMainTab()" class="protractor-test-main-tab">
<i class="material-icons">&#xE254;</i>
</a>
Expand All @@ -22,7 +22,7 @@
</li>

<!-- Settings -->
<li ng-class="{'active': getTabStatuses().active === 'settings'}">
<li ng-class="{'active': getActiveTabName() === 'settings'}">
<a href="#" uib-tooltip="Settings" tooltip-placement="bottom" ng-click="selectSettingsTab()" class="protractor-test-settings-tab">
<i class="material-icons">&#xE8B8;</i>
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ <h2>Suggestions to review</h2>
<script src="/templates/dev/head/services/ComputeGraphService.js"></script>
<script src="/templates/dev/head/services/EditabilityService.js"></script>
<script src="/templates/dev/head/services/GenerateContentIdService.js"></script>
<script src="/templates/dev/head/services/IssuesService.js"></script>
<script src="/templates/dev/head/services/ImprovementsService.js"></script>
<script src="/templates/dev/head/services/LocalStorageService.js"></script>
<script src="/templates/dev/head/services/SiteAnalyticsService.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,17 @@ oppia.directive('editorNavbarBreadcrumb', [
preview: 'Preview',
settings: 'Settings',
stats: 'Statistics',
improvements: 'Improvements',
history: 'History',
feedback: 'Feedback'
feedback: 'Feedback',
};

$scope.getCurrentTabName = function() {
if (!RouterService.getTabStatuses()) {
if (!RouterService.getActiveTabName()) {
return '';
} else {
return _TAB_NAMES_TO_HUMAN_READABLE_NAMES[
RouterService.getTabStatuses().active];
RouterService.getActiveTabName()];
}
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,23 @@ oppia.directive('editorNavigation', [
templateUrl: UrlInterpolationService.getDirectiveTemplateUrl(
'/pages/exploration_editor/editor_navigation_directive.html'),
controller: [
'$scope', '$rootScope', '$timeout', '$uibModal', 'ContextService',
'ExplorationRightsService', 'ExplorationWarningsService',
'RouterService', 'StateEditorTutorialFirstTimeService',
'SiteAnalyticsService', 'ThreadDataService', 'UserService',
'WindowDimensionsService',
'$rootScope', '$scope', '$timeout', '$uibModal', 'ContextService',
'ExplorationFeaturesService', 'ExplorationRightsService',
'ExplorationWarningsService', 'RouterService', 'SiteAnalyticsService',
'StateEditorTutorialFirstTimeService', 'ThreadDataService',
'UserService', 'WindowDimensionsService',
function(
$scope, $rootScope, $timeout, $uibModal, ContextService,
ExplorationRightsService, ExplorationWarningsService,
RouterService, StateEditorTutorialFirstTimeService,
SiteAnalyticsService, ThreadDataService, UserService,
WindowDimensionsService) {
$rootScope, $scope, $timeout, $uibModal, ContextService,
ExplorationFeaturesService, ExplorationRightsService,
ExplorationWarningsService, RouterService, SiteAnalyticsService,
StateEditorTutorialFirstTimeService, ThreadDataService,
UserService, WindowDimensionsService) {
$scope.popoverControlObject = {
postTutorialHelpPopoverIsShown: false
};
$scope.isLargeScreen = (WindowDimensionsService.getWidth() >= 1024);
$scope.isImprovementsTabEnabled =
ExplorationFeaturesService.isImprovementsTabEnabled;

$scope.$on('openPostTutorialHelpPopover', function() {
if ($scope.isLargeScreen) {
Expand Down Expand Up @@ -105,12 +107,14 @@ oppia.directive('editorNavigation', [
ExplorationWarningsService.hasCriticalWarnings);

$scope.ExplorationRightsService = ExplorationRightsService;
$scope.getTabStatuses = RouterService.getTabStatuses;
$scope.getActiveTabName = RouterService.getActiveTabName;
$scope.selectMainTab = RouterService.navigateToMainTab;
$scope.selectTranslationTab = RouterService.navigateToTranslationTab;
$scope.selectPreviewTab = RouterService.navigateToPreviewTab;
$scope.selectSettingsTab = RouterService.navigateToSettingsTab;
$scope.selectStatsTab = RouterService.navigateToStatsTab;
$scope.selectImprovementsTab =
RouterService.navigateToImprovementsTab;
$scope.selectHistoryTab = RouterService.navigateToHistoryTab;
$scope.selectFeedbackTab = RouterService.navigateToFeedbackTab;
$scope.getOpenThreadsCount = ThreadDataService.getOpenThreadsCount;
Expand Down
Loading