Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4936: The dropdown menus work similar to what the about and profile dropdown behave with the keyboard. #5974

Merged
merged 16 commits into from
Dec 28, 2018
Merged

Fix #4936: The dropdown menus work similar to what the about and profile dropdown behave with the keyboard. #5974

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
67b9b8b
#4936 adds tab and shift-tab navigation feature
geetchoudhary Dec 12, 2018
48547d8
section now closes when opened with mouseclick
geetchoudhary Dec 13, 2018
fce8fa3
Removed unwanted functions
geetchoudhary Dec 13, 2018
589b110
Fixed function issues - added necessary functions
geetchoudhary Dec 13, 2018
3416322
Added Service
geetchoudhary Dec 17, 2018
9fe23c1
Added service to top-navigation-bar
geetchoudhary Dec 18, 2018
fd1cb8c
Added NavigationService to aboutMenu
geetchoudhary Dec 24, 2018
ec3b68a
fixed linting errors
geetchoudhary Dec 24, 2018
92fce29
removed spaces
geetchoudhary Dec 24, 2018
4f7e88e
removed comments
geetchoudhary Dec 24, 2018
54dd656
made rootScope accessible in html
geetchoudhary Dec 24, 2018
62f866b
removed use of rootScope
geetchoudhary Dec 26, 2018
dee8702
resolved merge conflict
geetchoudhary Dec 26, 2018
fef273d
fixed pattern errors
geetchoudhary Dec 26, 2018
3fdf0e9
changed fileoverview
geetchoudhary Dec 26, 2018
b10980e
Merge branch 'develop' into tabnavigation
geetchoudhary Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unwanted functions
  • Loading branch information
@geetchoudhary
geetchoudhary committed Dec 13, 2018
commit fce8fa3be7dd192ffb533f721b637ec312733fe4
18 changes: 0 additions & 18 deletions core/templates/dev/head/pages/library/SearchBarDirective.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,6 @@ oppia.directive('searchBar', [
angular.element(evt.currentTarget).focus();
$scope.activeMenuName = menuName;
};
$scope.blurNavigationLinks = function(evt) {
// This is required because if about submenu is in open state
// and when you hover on library, both will be highlighted,
// To avoid that, blur all the a's in nav, so that only one
// will be highlighted.
$('nav a').blur();
};
$scope.closeSubmenu = function(evt) {
$scope.activeMenuName = '';
angular.element(evt.currentTarget).closest('li')
.find('a').blur();
};
$scope.closeSubmenuIfNotMobile = function(evt) {
if (DeviceInfoService.isMobileDevice()) {
return;
}
$scope.closeSubmenu(evt);
};
/**
* Handles keydown events on menus.
* @param {object} evt
Expand Down