Add test.

oppia · aks681 · Dec 10, 2018 · Aug 30, 2018 · Aug 30, 2018 · Aug 30, 2018
commit fd911896cb1e612cf55b495d4dbc2c3b8b898c81
@@ -294,3 +294,38 @@ def test_created_question_rights(self):
             Exception, 'Entity for class QuestionRightsModel with id '
             'question_id not found'):
             question_services.get_question_rights('question_id')
+
+    def test_get_question_skill_links_of_question(self):
+        # If the question id doesnt exist at all, it returns an empty list.
+        question_skill_links = (
+            question_services.get_question_skill_links_of_question(
+                'non_existent_question_id'))
+        self.assertEqual(len(question_skill_links), 0)
+
+        question_id_2 = question_services.get_new_question_id()
+        self.save_new_question(
+            question_id_2, self.editor_id,
+            self._create_valid_question_data('ABC'))
+
+        question_id_3 = question_services.get_new_question_id()
+        self.save_new_question(
+            question_id_3, self.editor_id,
+            self._create_valid_question_data('ABC'))
+        question_services.create_new_question_skill_link(
+            self.question_id, 'skill_1')
+        question_services.create_new_question_skill_link(
+            question_id_2, 'skill_1')
+        question_services.create_new_question_skill_link(
+            question_id_2, 'skill_2')
+        question_services.create_new_question_skill_link(
+            question_id_3, 'skill_2')
+
+            question_skill_links = (
+            question_services.get_question_skill_links_of_question(
+                question_id_2))
+
+        self.assertEqual(len(question_skill_links), 2)
+        skill_ids = [question_skill.skill_id for question_skill
+                        in question_skill_links]
+        self.assertItemsEqual(
+            update_skill_ids_of_questions, ['skill_1', 'skill_2'])
diff --git a/core/templates/dev/head/domain/question/EditableQuestionBackendApiServiceSpec.js b/core/templates/dev/head/domain/question/EditableQuestionBackendApiServiceSpec.js
@@ -74,7 +74,8 @@ describe('Editable question backend API service', function() {
         },
         language_code: 'en',
         version: 1
-      }
+      },
+      associated_skill_dicts: []
     };
   }));
 
@@ -95,7 +96,7 @@ describe('Editable question backend API service', function() {
       $httpBackend.flush();
 
       expect(successHandler).toHaveBeenCalledWith(
-        sampleDataResults.question_dict);
+        sampleDataResults);
       expect(failHandler).not.toHaveBeenCalled();
     }
   );
@@ -126,11 +127,10 @@ describe('Editable question backend API service', function() {
         sampleDataResults);
 
       EditableQuestionBackendApiService.fetchQuestion('0').then(
-        function(questionDict) {
-          question = questionDict;
+        function(data) {
+          question = data.question_dict;
         });
       $httpBackend.flush();
-
       question.question_state_data.content.html = 'New Question Content';
       question.version = '2';
       var questionWrapper = {

diff --git a/core/templates/dev/head/domain/question/QuestionUpdateServiceSpec.js b/core/templates/dev/head/domain/question/QuestionUpdateServiceSpec.js
@@ -0,0 +1,115 @@
+// Copyright 2018 The Oppia Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS-IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+/**
+ * @fileoverview Unit tests for question update service.
+ */
+
+describe('Question update service', function() {
+  var QuestionUpdateService = null;
+  var QuestionObjectFactory = null;
+  var QuestionUndoRedoService = null;
+  var StateObjectFactory = null;
+  var sampleQuestion = null;
+  var sampleStateTwo = null;
+
+  beforeEach(module('oppia'));
+
+  beforeEach(inject(function($injector) {
+    QuestionUpdateService = $injector.get('QuestionUpdateService');
+    QuestionObjectFactory = $injector.get('QuestionObjectFactory');
+    QuestionUndoRedoService = $injector.get('QuestionUndoRedoService');
+    StateObjectFactory = $injector.get('StateObjectFactory');
+
+    var sampleStateDict = {
+      name: 'question',
+      classifier_model_id: 0,
+      content: '<p>Hello World</p>',
+      param_changes: [],
+      interaction: {
+        answer_groups: [{
+          rule_specs: [{rule_type: 'Contains', inputs: {x: 'hola'}}],
+          outcome: {
+            dest: 'Me Llamo',
+            feedback: {html: 'buen trabajo!'},
+            labelled_as_correct: true
+          }
+        }],
+        default_outcome: {
+          dest: 'Hola',
+          feedback: {html: 'try again!'},
+          labelled_as_correct: false
+        },
+        hints: [],
+        id: 'TextInput',
+      },
+      content_ids_to_audio_translations: {}
+    };
+
+    var sampleStateDictTwo = {
+      name: 'question',
+      classifier_model_id: 0,
+      content: '<p>Hello World!!!</p>',
+      param_changes: [],
+      interaction: {
+        answer_groups: [{
+          rule_specs: [{rule_type: 'Contains', inputs: {x: 'hola'}}],
+          outcome: {
+            dest: 'My name is...',
+            feedback: {html: 'good job!'},
+            labelled_as_correct: true
+          }
+        }],
+        default_outcome: {
+          dest: 'Hello',
+          feedback: {html: 'try again!'},
+          labelled_as_correct: false
+        },
+        hints: [],
+        id: 'TextInput',
+      },
+      content_ids_to_audio_translations: {}
+    };
+
+    sampleStateTwo = StateObjectFactory.createFromBackendDict(
+      'question', sampleStateDictTwo);
+
+    var sampleQuestionBackendObject = {
+      id: '0',
+      question_state_data: sampleStateDict,
+      language_code: 'en',
+      version: 1
+    };
+    sampleQuestion = QuestionObjectFactory.createFromBackendDict(
+      sampleQuestionBackendObject);
+  }));
+
+  it('should update the language code of the question', function() {
+    expect(sampleQuestion.getLanguageCode()).toEqual('en');
+    QuestionUpdateService.setQuestionLanguageCode(sampleQuestion, 'zh');
+    expect(sampleQuestion.getLanguageCode()).toEqual('zh');
+    QuestionUndoRedoService.undoChange(sampleQuestion);
+    expect(sampleQuestion.getLanguageCode()).toEqual('en');
+  });
+
+  it('should update the state data of the question', function() {
+    var oldStateData = angular.copy(sampleQuestion.getStateData());
+    var newStateData = angular.copy(sampleStateTwo);
+    QuestionUpdateService.setQuestionStateData(
+      sampleQuestion, oldStateData, newStateData);
+    expect(sampleQuestion.getStateData()).toEqual(newStateData);
+    QuestionUndoRedoService.undoChange(sampleQuestion);
+    expect(sampleQuestion.getStateData()).toEqual(oldStateData);
+  });
+});