Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Chrome on Travis #5382

Merged
merged 5 commits into from
Jul 28, 2018
Merged

Attempt to fix Chrome on Travis #5382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abcaac5
Attempt to fix Chrome on Travis
apb7 Jul 27, 2018
db13e2c
Another attempt
apb7 Jul 27, 2018
4e80726
Another attempt
apb7 Jul 27, 2018
adca773
Another attempt: Update chromedriver
apb7 Jul 27, 2018
3f0cf71
Run all tests on Travis
apb7 Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ language: python
python:
- 2.7

addons:
chrome: stable

branches:
only:
- master
Expand Down Expand Up @@ -69,6 +66,8 @@ before_install:
- export CHROME_BIN=/usr/bin/google-chrome-stable
- export DISPLAY=:99.0
- bash -e /etc/init.d/xvfb start
- wget --no-verbose -O /tmp/$(basename $CHROME_SOURCE_URL) $CHROME_SOURCE_URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, what is CHROME_SOURCE_URL? Just wondering if it'll break in the future when Chrome updates again, and if it's possible to use something stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mentioned it in the PR description. I found a repository which stores deb files of various chrome versions: https://github.com/webnicer/chrome-downloads

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. Where are these "repository settings"? Should we document the procedure for updating to a newer version of Chrome here, in comments?

(We will have to do that eventually. But better that happen under our control, rather than under our feet and breaking us every time.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case there is a problem with the link, we can directly change it by modifying this environment variable in Travis's repo settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, in this file, you should provide instructions on how exactly to do that (in comments). It's the natural place that people will look.

Maybe in a separate PR after this one, though, since we want to get this one in as quickly as possible to unbreak develop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the Travis repository settings: https://travis-ci.org/oppia/oppia/settings
The environment variables are under the same-named header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks! I've merged this PR. Can you put these instructions in a comment here, as mentioned previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do this. Thanks!

- sudo dpkg -i /tmp/$(basename $CHROME_SOURCE_URL)

install:
- pushd $TRAVIS_BUILD_DIR
Expand Down
2 changes: 1 addition & 1 deletion scripts/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function maybeInstallDependencies {
install_node_module protractor-screenshot-reporter 0.0.5
install_node_module jasmine-spec-reporter 3.2.0

$NODE_MODULE_DIR/.bin/webdriver-manager update --versions.chrome 2.40
$NODE_MODULE_DIR/.bin/webdriver-manager update --versions.chrome 2.41
fi

if [ "$RUN_MINIFIED_TESTS" = "true" ]; then
Expand Down