oppia · apb7 · Aug 4, 2018 · Jul 19, 2018 · Jul 19, 2018 · Jul 19, 2018
@@ -170,8 +170,8 @@
     "space-before-function-paren": [
       "error",
       {
-        "anonymous": "ignore",
-        "asyncArrow": "ignore",
+        "anonymous": "never",
+        "asyncArrow": "never",
         "named": "never",
       }
     ],

@@ -6,6 +6,7 @@ gae_runtime/*
 third_party/*
 backend_prod_files/*
 core/templates/prod/*
+core/tests/.browserstack.env
 .coverage*
 .viminfo
 libpeerconnection.log

diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,11 @@ language: python
 python:
 - 2.7
 
+addons:
+  browserstack:
+    username: $USERNAME
+    access_key: $ACCESS_KEY
+
 branches:
   only:
   - master
@@ -22,13 +27,19 @@ env:
     - RUN_E2E_TESTS_ACCESSIBILITY=true
     - RUN_E2E_TESTS_COLLECTIONS=true
     - RUN_E2E_TESTS_EDITOR_AND_PLAYER=true
-    - RUN_E2E_TESTS_STATE_EDITOR=true
     - RUN_E2E_TESTS_EDITOR_FEATURES=true
     - RUN_E2E_TESTS_EMBEDDING=true
     - RUN_E2E_TESTS_EXTENSIONS=true
-    - RUN_E2E_TESTS_LEARNER_DASHBOARD=true
+    - RUN_E2E_TESTS_SUBSCRIPTIONS_AND_FEEDBACK_THREADS=true
+    - RUN_E2E_TESTS_LEARNER=true
     - RUN_E2E_TESTS_LIBRARY=true
+    - RUN_E2E_TESTS_LOGIN=true
+    - RUN_E2E_TESTS_PUBLICATION=true
+    - RUN_E2E_TESTS_STATE_EDITOR=true
+    - RUN_E2E_TESTS_SUBSCRIPTIONS=true
     - RUN_E2E_TESTS_USERS=true
+    # E2E tests for mobile.
+    - RUN_E2E_TESTS_MOBILE=true
 
 matrix:
   allow_failures: []
@@ -85,13 +96,19 @@ script:
 - if [ "$RUN_E2E_TESTS_ACCESSIBILITY" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="accessibility" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_COLLECTIONS" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="collections" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_EDITOR_AND_PLAYER" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="editorAndPlayer" --prod_env; fi
-- if [ "$RUN_E2E_TESTS_STATE_EDITOR" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="stateEditor" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_EDITOR_FEATURES" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="editorFeatures" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_EMBEDDING" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="embedding" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_EXTENSIONS" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="extensions" --prod_env; fi
-- if [ "$RUN_E2E_TESTS_LEARNER_DASHBOARD" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="learnerDashboard" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_SUBSCRIPTIONS_AND_FEEDBACK_THREADS" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="learnerDashboardSubscriptionsAndFeedbackThreads" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_LEARNER" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="learner" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_LIBRARY" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="library" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_LOGIN" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="login" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_PUBLICATION" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="publication" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_STATE_EDITOR" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="stateEditor" --prod_env; fi
+- if [ "$RUN_E2E_TESTS_SUBSCRIPTIONS" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="subscriptions" --prod_env; fi
 - if [ "$RUN_E2E_TESTS_USERS" == 'true' ]; then travis_retry bash scripts/run_e2e_tests.sh --suite="users" --prod_env; fi
+# Run e2e tests for mobile in dev mode since the demo explorations and collections are only available in the dev mode and not in production mode.
+- if [ "$RUN_E2E_TESTS_MOBILE" == 'true' ] && [ "$TRAVIS_BRANCH" == 'develop' ] && [ "$TRAVIS_EVENT_TYPE" == 'push' ] && [ "$TRAVIS_PULL_REQUEST" == 'false' ]; then travis_retry bash scripts/run_e2e_tests.sh --browserstack; fi
 
 after_success:
 - if [ "$RUN_BACKEND_TESTS" == 'true' ] && [ "$REPORT_BACKEND_COVERAGE" == 'true' ]; then codecov; fi

diff --git a/core/templates/dev/head/components/SolutionEditorDirective.js b/core/templates/dev/head/components/SolutionEditorDirective.js
@@ -52,7 +52,7 @@ oppia.directive('solutionEditor', [
             ui_config: {}
           };
 
-          $scope.getAnswerHtml = function () {
+          $scope.getAnswerHtml = function() {
             return ExplorationHtmlFormatterService.getAnswerHtml(
               StateSolutionService.savedMemento.correctAnswer,
               StateInteractionIdService.savedMemento,

diff --git a/core/templates/dev/head/components/side_navigation_bar/side_navigation_bar_directive.html b/core/templates/dev/head/components/side_navigation_bar/side_navigation_bar_directive.html
@@ -89,35 +89,35 @@
 
   <ul>
     <li ng-class="{'active': NAV_MODE === 'library'}">
-      <a href="/library">
+      <a href="/library" class="protractor-mobile-test-library-link">
         <i class="material-icons oppia-sidebar-menu-icon">&#xE88A;</i>
         <span translate="I18N_SIDEBAR_LIBRARY_LINK"></span>
       </a>
     </li>
 
     <li ng-class="{'active': NAV_MODE === 'about'}">
-      <a href="/about">
+      <a href="/about" class="protractor-mobile-test-about-link">
         <i class="material-icons oppia-sidebar-menu-icon">&#xE887;</i>
         <span translate="I18N_SIDEBAR_ABOUT_LINK"></span>
       </a>
     </li>
 
     <li ng-class="{'active': NAV_MODE === 'get_started'}">
-      <a href="/get_started">
+      <a href="/get_started" class="protractor-mobile-test-get-started-link">
         <i class="oppia-sidebar-menu-icon fa">&#xf135;</i>
         <span translate="I18N_SIDEBAR_GET_STARTED"></span>
       </a>
     </li>
 
     <li ng-class="{'active': NAV_MODE === 'teach'}">
-      <a href="/teach">
+      <a href="/teach" class="protractor-mobile-test-teach-link">
         <i class="material-icons oppia-sidebar-menu-icon">&#xE88E;</i>
         <span translate="I18N_SIDEBAR_TEACH_WITH_OPPIA"></span>
       </a>
     </li>
 
     <li ng-class="{'active': NAV_MODE === 'donate'}">
-      <a href="/donate">
+      <a href="/donate" class="protractor-mobile-test-donate-link">
         <i class="material-icons oppia-sidebar-menu-icon">&#xE87D;</i>
         <span translate="I18N_SIDEBAR_DONATE"></span>
       </a>
@@ -131,7 +131,7 @@
     </li>
 
     <li ng-class="{'active': NAV_MODE === 'contact'}">
-      <a href="/contact">
+      <a href="/contact" class="protractor-mobile-test-contact-link">
         <i class="material-icons oppia-sidebar-menu-icon">&#xE0BE;</i>
         <span translate="I18N_SIDEBAR_CONTACT_US"></span>
       </a>

diff --git a/core/templates/dev/head/components/summary_tile/CollectionSummaryTileDirective.js b/core/templates/dev/head/components/summary_tile/CollectionSummaryTileDirective.js
@@ -69,12 +69,12 @@ oppia.directive('collectionSummaryTile', [
             );
           };
 
-          $scope.getCompleteThumbnailIconUrl = function () {
+          $scope.getCompleteThumbnailIconUrl = function() {
             return UrlInterpolationService.getStaticImageUrl(
               $scope.getThumbnailIconUrl());
           };
 
-          $scope.getStaticImageUrl = function (url) {
+          $scope.getStaticImageUrl = function(url) {
             return UrlInterpolationService.getStaticImageUrl(url);
           };
 

diff --git a/core/templates/dev/head/components/summary_tile/ExplorationSummaryTileDirective.js b/core/templates/dev/head/components/summary_tile/ExplorationSummaryTileDirective.js
@@ -179,7 +179,7 @@ oppia.directive('explorationSummaryTile', [
             $scope.$apply();
           });
 
-          $scope.getCompleteThumbnailIconUrl = function () {
+          $scope.getCompleteThumbnailIconUrl = function() {
             return UrlInterpolationService.getStaticImageUrl(
               $scope.getThumbnailIconUrl());
           };

diff --git a/core/templates/dev/head/components/summary_tile/exploration_summary_tile_directive.html b/core/templates/dev/head/components/summary_tile/exploration_summary_tile_directive.html
@@ -72,7 +72,7 @@ <h3 class="activity-title protractor-test-exp-summary-tile-title" ng-style="isPl
           </span>
         </li>
       </ul>
-      <button ng-if="isCollectionPreviewTile" class="oppia-learner-confirm-button md-button md-default-theme"
+      <button ng-if="isCollectionPreviewTile" class="oppia-learner-confirm-button md-button md-default-theme protractor-test-play-exploration-button"
               style="display: block; margin: auto; touch-action: pan-y; user-select: none; -webkit-user-drag: none; -webkit-tap-highlight-color: rgba(0, 0, 0, 0);">
         <span translate="I18N_PLAYER_PLAY_EXPLORATION"></span>
       </button>

diff --git a/core/templates/dev/head/components/top_navigation_bar/top_navigation_bar_directive.html b/core/templates/dev/head/components/top_navigation_bar/top_navigation_bar_directive.html
@@ -1,6 +1,7 @@
 <div class="navbar-header protractor-test-navbar-header pull-left">
   <a ng-if="windowIsNarrow" ng-click="toggleSidebar()"
-     class="navbar-brand oppia-navbar-menu oppia-transition-200" tabindex="0">
+     class="navbar-brand oppia-navbar-menu oppia-transition-200 protractor-mobile-test-navbar-button"
+     tabindex="0">
     <i class="material-icons oppia-navbar-menu-icon" ng-if="!isSidebarShown()" >&#xE5D2;</i>
     <i class="material-icons oppia-navbar-close-icon" ng-if="isSidebarShown()" >&#10005;</i>
   </a>
@@ -112,13 +113,13 @@
         <hr class="oppia-top-right-menu-item-separator">
         <li>
           <a ng-click="closeSubmenuIfNotMobile($event)" href="/creator_dashboard"
-             class="protractor-test-dashboard-link">
+             class="protractor-test-dashboard-link protractor-test-creator-dashboard-link">
             <span translate="I18N_TOPNAV_CREATOR_DASHBOARD"></span>
           </a>
         </li>
         <li>
           <a ng-click="closeSubmenuIfNotMobile($event)" href="/learner_dashboard"
-             class="protractor-test-dashboard-link">
+             class="protractor-test-dashboard-link protractor-test-learner-dashboard-link">
             <span translate="I18N_TOPNAV_LEARNER_DASHBOARD"></span>
           </a>
         </li>
@@ -161,7 +162,7 @@
 
     <li uib-dropdown ng-if="!username" class="oppia-navbar-clickable-dropdown">
       <div class="oppia-navbar-button-container" style="margin-right: 10px;">
-        <button class="btn oppia-navbar-button"
+        <button class="btn oppia-navbar-button protractor-mobile-test-login"
                 ng-click="onLoginButtonClicked()">
           <span translate="I18N_TOPNAV_SIGN_IN"></span>
           <span class="caret"></span>

diff --git a/core/templates/dev/head/domain/exploration/SolutionObjectFactorySpec.js b/core/templates/dev/head/domain/exploration/SolutionObjectFactorySpec.js
@@ -21,7 +21,7 @@ describe('Solution object factory', function() {
 
   describe('SolutionObjectFactory', function() {
     var scope, sof, solution;
-    beforeEach(inject(function ($injector, $rootScope) {
+    beforeEach(inject(function($injector, $rootScope) {
       scope = $rootScope.$new();
       sof = $injector.get('SolutionObjectFactory');
       solution = sof.createFromBackendDict({

diff --git a/core/templates/dev/head/domain/objects/FractionObjectFactory.js b/core/templates/dev/head/domain/objects/FractionObjectFactory.js
@@ -34,7 +34,7 @@ oppia.factory('FractionObjectFactory', [
       this.denominator = denominator;
     };
 
-    Fraction.prototype.toString = function () {
+    Fraction.prototype.toString = function() {
       var fractionString = '';
       if (this.numerator !== 0) {
         fractionString += this.numerator + '/' + this.denominator;
@@ -60,17 +60,17 @@ oppia.factory('FractionObjectFactory', [
       };
     };
 
-    Fraction.prototype.toFloat = function () {
+    Fraction.prototype.toFloat = function() {
       var totalParts = (this.wholeNumber * this.denominator) + this.numerator;
       var floatVal = (totalParts / this.denominator);
       return this.isNegative ? -floatVal : floatVal;
     };
 
-    Fraction.prototype.getIntegerPart = function () {
+    Fraction.prototype.getIntegerPart = function() {
       return this.isNegative ? -this.wholeNumber : this.wholeNumber;
     };
 
-    Fraction.prototype.convertToSimplestForm = function () {
+    Fraction.prototype.convertToSimplestForm = function() {
       var gcd = function(x, y) {
         return y === 0 ? x : gcd(y, x % y);
       };

diff --git a/core/templates/dev/head/domain/utilities/UrlInterpolationServiceSpec.js b/core/templates/dev/head/domain/utilities/UrlInterpolationServiceSpec.js
@@ -30,7 +30,7 @@ describe('URL Interpolation Service', function() {
     GLOBALS.DEV_MODE = true;
   });
 
-  it('should add hash to url if hash is set', function () {
+  it('should add hash to url if hash is set', function() {
     expect(uis._getUrlWithSlug('/hash_test.html')).toBe(
       '/hash_test.' + hashes['/hash_test.html'] + '.html'
     );
@@ -42,7 +42,7 @@ describe('URL Interpolation Service', function() {
     );
   });
 
-  it('should build complete URL with prefixes and hash', function () {
+  it('should build complete URL with prefixes and hash', function() {
     expect(uis._getCompleteUrl('/test_folder', '/hash_test.html')).toBe(
       '/build/test_folder/hash_test.' + hashes['/hash_test.html'] + '.html'
     );

diff --git a/core/templates/dev/head/pages/collection_player/collection_player.html b/core/templates/dev/head/pages/collection_player/collection_player.html
@@ -239,7 +239,7 @@ <h2 ng-if="collectionPlaythrough.hasFinishedCollection()" class="oppia-page-head
         <img ng-src="<[getStaticImageUrl('/general/collection_mascot.svg')]>" class="mobile-lesson-icon">
         <div class="mobile-path-segment" ng-repeat="node in collection.getCollectionNodes()" id="mobile-path-anchor-<[$index]>">
           <a href="" style="position: absolute; left: 50%; transform: translate(-50%, 195px); z-index: 1;">
-            <svg class="protractor-test-collection-exploration"
+            <svg class="protractor-mobile-test-collection-exploration"
                  width="100"
                  height="150"
                  xmlns="http://www.w3.org/2000/svg"

diff --git a/core/templates/dev/head/pages/creator_dashboard/CreatorDashboard.js b/core/templates/dev/head/pages/creator_dashboard/CreatorDashboard.js
@@ -185,7 +185,7 @@ oppia.controller('CreatorDashboard', [
       return value;
     };
 
-    $scope.getCompleteThumbnailIconUrl = function (iconUrl) {
+    $scope.getCompleteThumbnailIconUrl = function(iconUrl) {
       return UrlInterpolationService.getStaticImageUrl(iconUrl);
     };
 

diff --git a/core/templates/dev/head/pages/creator_dashboard/creator_dashboard.html b/core/templates/dev/head/pages/creator_dashboard/creator_dashboard.html
@@ -114,7 +114,7 @@ <h2 class="oppia-dashboard-title" translate="I18N_DASHBOARD_CREATOR_DASHBOARD"><
           <div>
             <p translate="I18N_DASHBOARD_EXPLORATIONS_EMPTY_MESSAGE"></p>
             <button type="button"
-                    class="btn oppia-dashboard-intro-button oppia-transition-200"
+                    class="btn oppia-dashboard-intro-button oppia-transition-200 protractor-test-create-new-exploration-button"
                     ng-click="createNewExploration()"
                     translate="I18N_CREATE_EXPLORATION">
             </button>

diff --git a/core/templates/dev/head/pages/exploration_editor/ExplorationObjectiveEditorDirective.js b/core/templates/dev/head/pages/exploration_editor/ExplorationObjectiveEditorDirective.js
@@ -33,7 +33,7 @@ oppia.directive('explorationObjectiveEditor', [
         'exploration_objective_editor_directive.html'),
       controller: [
         '$scope', 'ExplorationObjectiveService',
-        function ($scope, ExplorationObjectiveService) {
+        function($scope, ExplorationObjectiveService) {
           $scope.explorationObjectiveService = ExplorationObjectiveService;
         }
       ]

diff --git a/.../templates/dev/head/pages/exploration_editor/editor_tab/InteractionDetailsCacheService.js b/.../templates/dev/head/pages/exploration_editor/editor_tab/InteractionDetailsCacheService.js
@@ -29,7 +29,7 @@ oppia.factory('InteractionDetailsCacheService', [function() {
     contains: function(interactionId) {
       return _cache.hasOwnProperty(interactionId);
     },
-    removeDetails: function (interactionId) {
+    removeDetails: function(interactionId) {
       delete _cache[interactionId];
     },
     set: function(interactionId, interactionCustomizationArgs) {

diff --git a/core/templates/dev/head/pages/exploration_editor/editor_tab/ResponsesService.js b/core/templates/dev/head/pages/exploration_editor/editor_tab/ResponsesService.js
@@ -126,7 +126,7 @@ oppia.factory('ResponsesService', [
       callback(_answerGroupsMemento);
     };
 
-    var _updateAnswerGroupsAudioTranslation = function () {
+    var _updateAnswerGroupsAudioTranslation = function() {
       StateContentIdsToAudioTranslationsService.displayed.
         deleteAllFeedbackContentId();
       for (var i = 0; i < _answerGroups.length; i++) {

diff --git a/core/templates/dev/head/pages/exploration_editor/editor_tab/SolutionValidityServiceSpec.js b/core/templates/dev/head/pages/exploration_editor/editor_tab/SolutionValidityServiceSpec.js
@@ -29,7 +29,7 @@ describe('Solution Validity Service', function() {
       svs = $injector.get('SolutionValidityService');
 
       it('should store validity of the solution correctly',
-        function () {
+        function() {
           // Initialize SolutionValidityService.
           svs.init();
 

diff --git a/core/templates/dev/head/pages/exploration_editor/statistics_tab/PieChartDirective.js b/core/templates/dev/head/pages/exploration_editor/statistics_tab/PieChartDirective.js
@@ -36,7 +36,7 @@ oppia.directive('pieChart', [function() {
 
       // Need to wait for load statement in editor template to finish.
       // https://stackoverflow.com/questions/42714876/
-      google.charts.setOnLoadCallback(function () {
+      google.charts.setOnLoadCallback(function() {
         if (!chart) {
           chart = new google.visualization.PieChart($element[0]);
         }

diff --git a/core/templates/dev/head/pages/learner_dashboard/LearnerDashboard.js b/core/templates/dev/head/pages/learner_dashboard/LearnerDashboard.js
@@ -270,7 +270,7 @@ oppia.controller('LearnerDashboard', [
           ui.placeholder.height(ui.item.height());
           $scope.$apply();
         },
-        sort: function (e, ui) {
+        sort: function(e, ui) {
           /* eslint-disable quote-props */
           // Reset the position of the window on scrolling. This keeps the mouse
           // position and elements in sync.

diff --git a/core/templates/dev/head/pages/learner_dashboard/learner_dashboard.html b/core/templates/dev/head/pages/learner_dashboard/learner_dashboard.html
@@ -64,7 +64,7 @@ <h1 class="stat-value"><[subscriptionsList.length]></h1>
           <p class="oppia-learner-dashboard-intro-card-message" style="padding-top: 15px;"
              translate="I18N_LEARNER_DASHBOARD_INTRO_MESSAGE_PART_TWO">
           </p>
-          <a class="btn oppia-learner-dashboard-intro-button oppia-transition-200"
+          <a class="btn oppia-learner-dashboard-intro-button oppia-transition-200 protractor-mobile-test-learner-dashboard-intro-button"
              translate="I18N_ACTION_BROWSE_LESSONS"
              ng-href="/library">
           </a>

diff --git a/core/templates/dev/head/pages/library/Library.js b/core/templates/dev/head/pages/library/Library.js
@@ -136,7 +136,7 @@ oppia.controller('Library', [
 
         // Check if actual and expected widths are the same.
         // If not produce an error that would be caught by e2e tests.
-        $timeout(function () {
+        $timeout(function() {
           var actualWidth = $('exploration-summary-tile').width();
           if (actualWidth && actualWidth !== LIBRARY_TILE_WIDTH_PX) {
             console.error(

diff --git a/core/templates/dev/head/pages/skill_editor/editor_tab/SkillConceptCardEditorDirective.js b/core/templates/dev/head/pages/skill_editor/editor_tab/SkillConceptCardEditorDirective.js
@@ -18,7 +18,7 @@
 
 oppia.directive('skillConceptCardEditor', [
   'UrlInterpolationService', 'SkillUpdateService', 'SkillEditorStateService',
-  function (
+  function(
       UrlInterpolationService, SkillUpdateService, SkillEditorStateService) {
     return {
       restrict: 'E',