Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Backend Call API from the StateTopAnswerStatisticsService #5079

Merged
merged 28 commits into from
Jun 10, 2018
Merged

Split Backend Call API from the StateTopAnswerStatisticsService #5079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
899b17a
Split backend api calls from the service.
brianrodri Jun 9, 2018
375a248
Make backend API service initialize the service when exploration is f…
brianrodri Jun 9, 2018
eff8d1c
s/fetchExploration/fetchStats
brianrodri Jun 9, 2018
5989c94
Don't use promise.
brianrodri Jun 9, 2018
89f47fe
Rever whitespace changes.
brianrodri Jun 9, 2018
43f64c1
Remove httpBackend from spec.
brianrodri Jun 9, 2018
44feafe
Add isInitialized with tests.
brianrodri Jun 9, 2018
998ec4d
Make backend dict same as what's returned.
brianrodri Jun 9, 2018
1c250a0
nit: add space.
brianrodri Jun 9, 2018
38765cf
Combine beforeEach.
brianrodri Jun 10, 2018
93b74c2
Import new backend api
brianrodri Jun 10, 2018
ed7e02d
Depend on new services.
brianrodri Jun 10, 2018
83ac575
Use for each loop.
brianrodri Jun 10, 2018
8c7cc57
Respect None return values.
brianrodri Jun 10, 2018
5a757f8
Add imports to exploration_editor
brianrodri Jun 10, 2018
6a834e1
Move files
brianrodri Jun 10, 2018
62783c2
Merge remote-tracking branch 'upstream/develop' into stas-for-real
brianrodri Jun 10, 2018
3bea040
Add answers nesting.
brianrodri Jun 10, 2018
35bbe3d
Fix test to include answers wrapping.
brianrodri Jun 10, 2018
33416d9
nit: remove extra line.
brianrodri Jun 10, 2018
60c08e5
Add whitespace again.
brianrodri Jun 10, 2018
8d060ce
Fix endswith newline lint error.
brianrodri Jun 10, 2018
70e178f
Use Top10AnswerFrequencies calculation.
brianrodri Jun 10, 2018
6cae980
Merge remote-tracking branch 'upstream/develop' into stas-for-real
brianrodri Jun 10, 2018
7b42bb8
Consistent passing of url interpolation values.
brianrodri Jun 10, 2018
3b01ca1
s/AnswerStatsFactory/AnswerStatsObjectFactory
brianrodri Jun 10, 2018
7acde1a
Organize inports.
brianrodri Jun 10, 2018
f57a4b3
Better worded comment.
brianrodri Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
s/fetchExploration/fetchStats
  • Loading branch information
@brianrodri
brianrodri committed Jun 9, 2018
commit eff8d1ce2548a2f95ecab18cde7224bcca31dd34
2 changes: 1 addition & 1 deletion core/templates/dev/head/domain/exploration/StateTopAnswersStatsBackendApiService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
oppia.factory('StateTopAnswersStatsBackendApiService', [
'$http', 'UrlInterpolationService', function($http, UrlInterpolationService) {
return {
fetchExploration: function(explorationId) {
fetchStats: function(explorationId) {
return $http.get(
UrlInterpolationService.interpolateUrl(
'/createhandler/state_answer_stats/<exploration_id>', {
Expand Down
4 changes: 2 additions & 2 deletions core/templates/dev/head/domain/exploration/StateTopAnswersStatsBackendApiServiceSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('StateTopAnswersStatsBackendApiService', function() {
this.$httpBackend.verifyNoOutstandingRequest();
});

describe('.fetchExploration', function() {
describe('.fetchStats', function() {
beforeEach(function() {
this.sampleData = {
answers: {
Expand All @@ -51,7 +51,7 @@ describe('StateTopAnswersStatsBackendApiService', function() {
'/createhandler/state_answer_stats/7'
).respond(this.sampleData);

this.StateTopAnswersStatsBackendApiService.fetchExploration('7').then(
this.StateTopAnswersStatsBackendApiService.fetchStats('7').then(
successHandler, failureHandler);
this.$httpBackend.flush();

Expand Down
2 changes: 1 addition & 1 deletion core/templates/dev/head/pages/exploration_editor/ExplorationEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ oppia.controller('ExplorationEditor', [

if (ExplorationRightsService.isPublic()) {
// Don't make user wait on stats to begin editing the exploration.
StateTopAnswersStatsBackendApiService.fetchExploration(
StateTopAnswersStatsBackendApiService.fetchStats(
$scope.explorationId
).then(StateTopAnswersStatsService.init);
}
Expand Down