Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4781: Fixed Code editor zoom in problem #4921

Merged
merged 4 commits into from
May 15, 2018
Merged

Fix #4781: Fixed Code editor zoom in problem #4921

merged 4 commits into from
May 15, 2018

Conversation

bansalnitish
Copy link
Contributor

@bansalnitish bansalnitish commented May 9, 2018 •
edited
Loading

Explanation

Fixes #4781

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

codecov-io commented May 9, 2018 •
edited
Loading

Codecov Report

Merging #4921 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4921   +/-   ##
========================================
  Coverage    44.16%   44.16%           
========================================
  Files          386      386           
  Lines        23289    23289           
  Branches      3789     3789           
========================================
  Hits         10286    10286           
  Misses       13003    13003

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5287fdc...215f7da. Read the comment docs.

DubeySandeep
DubeySandeep reviewed May 9, 2018
View reviewed changes
core/templates/dev/head/pages/exploration_player/progress_nav_directive.html Outdated
@@ -1,4 +1,4 @@
<div layout="row" layout-align="space-between center" style="background-color: white;">
<div layout="row" layout-align="space-between center" style="background-color: white; margin-left: 87px">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bansalnitish, Add some comments explaining the 87px. (as done in earlier PR!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

nithusha21
nithusha21 suggested changes May 12, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bansalnitish! The correctness footer is misaligned, and the formatting of the tutor card is broken for other screen sizes.
image

Please fix that for different screen sizes.

@bansalnitish
Copy link
Contributor Author

Thanks @nithusha21 for the review. I have updated the PR can you PTAL?

@nithusha21
Copy link
Contributor

The correctness footer is correctly aligned. But the grey area beside the continue button is present at screen sizes below 950px. Could you take a look at that?

@nithusha21
Copy link
Contributor

Just mentioning, I haven't actually tested the original issue. These were things that broke last release while we reverted #4783.

@bansalnitish
Copy link
Contributor Author

Hi @nithusha21,
Can you please add screenshots of the same? (The grey area is not visible now I think.)

nithusha21
nithusha21 approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior LGTM. Thanks @bansalnitish.

@pranavsid98 pranavsid98 merged commit 7d1746d into oppia:develop May 15, 2018
@bansalnitish bansalnitish deleted the fixCodeEditor branch June 8, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DubeySandeep DubeySandeep DubeySandeep left review comments

@nithusha21 nithusha21 nithusha21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bansalnitish @codecov-io @nithusha21 @DubeySandeep @pranavsid98