Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GAE version to 1.9.67. #4786

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Upgrade GAE version to 1.9.67. #4786

merged 1 commit into from
Mar 8, 2018

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Mar 7, 2018

This should prevent issues like #4784, I think. See the May 15, 2017 entry here.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #4786 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4786   +/-   ##
========================================
  Coverage    44.74%   44.74%           
========================================
  Files          385      385           
  Lines        23463    23463           
  Branches      3793     3793           
========================================
  Hits         10498    10498           
  Misses       12965    12965

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cfcdf...a267516. Read the comment docs.

Copy link
Contributor

@AllanYangZhou AllanYangZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it w/o errors, LGTM!

@seanlip seanlip merged commit 2629209 into develop Mar 8, 2018
@seanlip seanlip deleted the upgrade-gae branch March 8, 2018 16:57
giritheja added a commit to giritheja/oppia that referenced this pull request Mar 12, 2018
* upstream/develop: (114 commits)
  Fix line too long (oppia#4798)
  Fix oppia#4374: Docstrings added to core/domain/stats_jobs_one_off.py (oppia#4757)
  Fixes oppia#4055: Removes redundant css selector from conversation_skin_directive.html (oppia#4790)
  Fix oppia#3971: add activity indicator to feedback updates (oppia#4785)
  Fix part of oppia#4374 : Update docstrings to core.domain.stats_domain. (oppia#4731)
  Fix oppia#2620 (oppia#4791)
  Removes unused angular dependecies injected into controllers (oppia#4792)
  Fix oppia#4367 : Prevent null-submission for MathExpressionInput interaction (Upgraded guppy 260da6--->b5055b) (oppia#4753)
  Upgrade GAE version to 1.9.67. (oppia#4786)
  Fix #4781: Fixed zoom in Problem with code editor (oppia#4783)
  Changed timeout for popup to 4 seconds. (oppia#4706)
  Fixes oppia#3982 : Added 'open' in the open feedback thread summary. (#4767)
  Fix oppia#4778: Changed is_community_owned to make_community_owned. (oppia#4780)
  Revert "Fixes #4530: Removes spaces and new lines from end of string in RTE. (#4748)" (oppia#4782)
  Fixed oppia#4537: Navigating between admin pages on url change (oppia#4777)
  Added $log dependency in missing places. (oppia#4772)
  Add missing dependency. (oppia#4769)
  Fix oppia#3478: Added functionality to sort nodes list. (oppia#4708)
  Fixes #4530: Removes spaces and new lines from end of string in RTE. (#4748)
  Fixes oppia#4410: Fixed info modal for private explorations (#4754)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants