Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #3550: Move translation check from footer to header #4738

Merged
merged 6 commits into from
Feb 27, 2018
Merged

Fix part of #3550: Move translation check from footer to header #4738

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ad25bc
Move translation to top nav bar.
tjiang11 Feb 3, 2018
b2d1f9f
Save changes.
tjiang11 Feb 5, 2018
ef11beb
Remove unused.
tjiang11 Feb 24, 2018
5ad1c21
Add path to translate.
tjiang11 Feb 24, 2018
24ad954
Lint.
tjiang11 Feb 24, 2018
fd56286
Remove cookies import.
tjiang11 Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused.
  • Loading branch information
@tjiang11
tjiang11 committed Feb 24, 2018
commit ef11bebcaf7ad884f10f589c741c7c96db76fdb7
4 changes: 0 additions & 4 deletions core/templates/dev/head/components/top_navigation_bar/TopNavigationBarDirective.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ oppia.directive('topNavigationBar', [
$scope, $http, $window, $timeout, $translate, $cookies,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why import $cookies at all?

SidebarStatusService, LABEL_FOR_CLEARING_FOCUS,
siteAnalyticsService, WindowDimensionsService, DebouncerService) {
$cookies.remove('NG_TRANSLATE_LANG_KEY');
$cookies.put('test', 'value', {path: '/'});
console.log("tsss");
if (GLOBALS.userIsLoggedIn && GLOBALS.preferredSiteLanguageCode) {
//$cookies.remove('NG_TRANSLATE_LANG_KEY', {path: '/'});
$translate.use(GLOBALS.preferredSiteLanguageCode);
}

Expand Down