Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation order for release-scripts #21586

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Fix installation order for release-scripts #21586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix installation order for release-scripts
  • Loading branch information
@seanlip
seanlip committed Jan 1, 2025
commit b51ebd7e623920fd6dfaec7da737faffdcd43c08
19 changes: 10 additions & 9 deletions scripts/install_third_party_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,16 @@ def install_gcloud_sdk() -> None:

os.remove('gcloud-sdk.tar.gz')

# Install specific google cloud components for the Google Cloud SDK. The
# --quiet flag specifically tells the gcloud program to autofill all
# prompts with default values. In this case, that means accepting all
# installations of gcloud packages.
subprocess.run([
common.GCLOUD_PATH, 'components', 'install', 'beta',
'cloud-datastore-emulator', 'app-engine-python',
'app-engine-python-extras', '--quiet',
], check=True)

# Address the problem of multiple google paths confusing the python
# interpreter. Namely, there are two modules named google/, one that is
# installed with google cloud libraries and another that comes with the
Expand Down Expand Up @@ -243,15 +253,6 @@ def install_gcloud_sdk() -> None:

sys.path.append('.')
sys.path.append(common.GOOGLE_APP_ENGINE_SDK_HOME)
# Install specific google cloud components for the Google Cloud SDK. The
# --quiet flag specifically tells the gcloud program to autofill all
# prompts with default values. In this case, that means accepting all
# installations of gcloud packages.
subprocess.run([
common.GCLOUD_PATH, 'components', 'install', 'beta',
'cloud-datastore-emulator', 'app-engine-python',
'app-engine-python-extras', '--quiet',
], check=True)

print('Google Cloud SDK is installed.')

Expand Down
Loading